Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Nov 2018 05:21:14 +0000
From:      bugzilla-noreply@freebsd.org
To:        fs@FreeBSD.org
Subject:   [Bug 233245] [UFS] [enhancement] Softupdates fails to track dependency between appended data and i_size
Message-ID:  <bug-233245-3630-x4ISMZdara@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-233245-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-233245-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233245

--- Comment #7 from Conrad Meyer <cem@freebsd.org> ---
(In reply to Kirk McKusick from comment #6)
Ok, I will leave it on the fs list then.

> In about 2000 I used the `special topics' lecture of my advanced code rea=
ding
> class to do a walk-through of the soft updates code. It is a 2.5 hour vid=
eo of
> me going through softdep.h and ffs_softdep.c. It predates the addition of=
 the
> journaling support, so reflects a simpler time, but is probably still use=
ful to
> get a general understanding. I would be willing to make the video availab=
le to
> you if you want to watch it.

I think my employer has licensed some of your video series, but none
specifically annotated as around 2000.  I see a 2006 "data structures" seri=
es
where #6 covers UFS, including SU, and a 2009 "intensive code walkthrough"
series where #15 is a "special topics," including soft updates.  I don't
suppose you're referring to one of those?  If not, I would certainly apprec=
iate
a copy of the video.

> I believe that commenting code is very important and have tried to do a g=
ood
> job of it in the soft updates code. So I strongly encourage you to work to
> improve it. Often the original author overlooks things that seem obvious =
to
> them but in fact are confusing to those that are not intimately familiar =
with
> the code.

Absolutely!

> So filling in those gaps is a valuable addition.

Ok, great.  Sounds like I have plenty of direction in how to proceed. :-)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233245-3630-x4ISMZdara>