Date: Thu, 18 Apr 2024 18:12:27 GMT From: Mitchell Horne <mhorne@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 5eb27a0d68f5 - stable/14 - clk_fixed: quiet by default Message-ID: <202404181812.43IICRhv016234@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=5eb27a0d68f5b7cd64d5a269b727c5f22185a40c commit 5eb27a0d68f5b7cd64d5a269b727c5f22185a40c Author: Mitchell Horne <mhorne@FreeBSD.org> AuthorDate: 2024-03-08 14:08:49 +0000 Commit: Mitchell Horne <mhorne@FreeBSD.org> CommitDate: 2024-04-18 18:11:31 +0000 clk_fixed: quiet by default We may attach several of these devices, but there is no meaningful information added to dmesg. For example: ofwbus0: <Open Firmware Device Tree> clk_fixed0: <Fixed clock> on ofwbus0 clk_fixed1: <Fixed clock> on ofwbus0 clk_fixed2: <Fixed clock> on ofwbus0 clk_fixed3: <Fixed clock> on ofwbus0 clk_fixed4: <Fixed clock> on ofwbus0 clk_fixed5: <Fixed clock> on ofwbus0 clk_fixed6: <Fixed clock> on ofwbus0 clk_fixed7: <Fixed clock> on ofwbus0 clk_fixed8: <Fixed clock> on ofwbus0 clk_fixed9: <Fixed clock> on ofwbus0 clk_fixed10: <Fixed clock> on ofwbus0 clk_fixed11: <Fixed clock> on ofwbus0 To reduce this noise, quiet the devices for by default. For verbose boot, the message will be emitted. Reviewed by: manu MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D44266 (cherry picked from commit 1cb9f6f6413e9d242de47e730ec7d4ce3e5688fe) --- sys/dev/extres/clk/clk_fixed.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sys/dev/extres/clk/clk_fixed.c b/sys/dev/extres/clk/clk_fixed.c index e5ca6b31d000..1a61f0013bb2 100644 --- a/sys/dev/extres/clk/clk_fixed.c +++ b/sys/dev/extres/clk/clk_fixed.c @@ -163,13 +163,18 @@ clk_fixed_probe(device_t dev) return (ENXIO); } device_set_desc(dev, "Fixed clock"); - return (BUS_PROBE_DEFAULT); + break; case CLK_TYPE_FIXED_FACTOR: device_set_desc(dev, "Fixed factor clock"); - return (BUS_PROBE_DEFAULT); + break; default: return (ENXIO); } + + if (!bootverbose) + device_quiet(dev); + + return (BUS_PROBE_DEFAULT); } static int
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202404181812.43IICRhv016234>