Date: Sun, 21 Oct 2018 16:04:15 +0000 From: Glen Barber <gjb@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: Jan Beich <jbeich@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339436 - in head: . contrib/gcc gnu/usr.bin/cc/cc_tools lib/clang release sys/conf sys/sys Message-ID: <20181021160415.GD13668@FreeBSD.org> In-Reply-To: <20181021154520.GB13668@FreeBSD.org> References: <201810190037.w9J0blks031617@repo.freebsd.org> <o9bo-oxuj-wny@FreeBSD.org> <F64E20B4-576A-44DA-B727-EFDA7D4EF51E@FreeBSD.org> <20181021154520.GB13668@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Sun, Oct 21, 2018 at 03:45:20PM +0000, Glen Barber wrote:
> On Sun, Oct 21, 2018 at 11:55:20AM +0200, Dimitry Andric wrote:
> > On 21 Oct 2018, at 04:08, Jan Beich <jbeich@FreeBSD.org> wrote:
> > >
> > > Glen Barber <gjb@FreeBSD.org> writes:
> > >
> > >> Modified: head/lib/clang/llvm.build.mk
> > >> ==============================================================================
> > >> --- head/lib/clang/llvm.build.mk Fri Oct 19 00:24:23 2018 (r339435)
> > >> +++ head/lib/clang/llvm.build.mk Fri Oct 19 00:37:47 2018 (r339436)
> > >> @@ -17,7 +17,7 @@ CFLAGS+= -I${LLVM_SRCS}/include
> > >> CFLAGS+= -DLLVM_BUILD_GLOBAL_ISEL
> > >> CFLAGS+= -D__STDC_LIMIT_MACROS
> > >> CFLAGS+= -D__STDC_CONSTANT_MACROS
> > >> -#CFLAGS+= -DNDEBUG
> > >> +CFLAGS+= -DNDEBUG
> > >
> > > Would Clang still hit asserts instead of crashing with cryptic messages?
> >
> > In llvm, assertions (and various other internal consistency checks) are
> > turned off by defining NDEBUG. So indeed, if something in the internal
> > state goes in an unexpected direction, you could get crashes or other
> > "interesting" effects.
> >
> > That said, the resulting executable(s) should run somewhat faster, and
> > be somewhat smaller. I think we have always done this for stable
> > branches and releases.
> >
>
> I think I screwed up, and changed this in the wrong branch. I'm looking
> into the "why", but the commit to head in this case should be reverted
> (I'll take care of it if it was not already done), and this particular
> change should be applied to stable/12 (which I will also take care of).
> I first want to look through our docs to understand how I messed this
> up.
>
Ok, reverted in head as of r339541, and the commit to apply the change
to stable/12 is sent to re@ for approval.
Glen
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAlvMo38ACgkQAxRYpUeP
4pMNJg/+PsEegAg3ctENiVnouQ3BNQaCZ+ev984qSf+THdBfR1PSZI9wimc3PryK
Ma0jtZVx/q5ZhnNkTnSIRNwG8WRGuwCn3ep3r6DzkMcmD+KGdi54R0JRPOI5buH6
7iJk4mB9lMM3XikqjhuIYO79mtvxPIrZHHY0wXZpI5kxUTMIqj0vE29h1UnUj4GK
o3c9jUWlOAwVS52J3oTDhFlZuyvWvkPePhAKyoXAmJndOuZLIKXsZbE6wXgK1GhX
LLCJIIA4Ldw/iocNMWv2vAZdiC7yS+6ccJXUmAG5G2OX0gYAuLnbFUohUuNj87Ax
0A53SGGxzYGjnOXfToYJsZ+eT1Rcv4n3P2CFHMwAaPZjfNiys1bZ7USYYmVEszIQ
8gD6GXt7HO1BbcEux3KPtaboSN2a2jZiDnG8OYPNZnIDwGmerzcC5bh01p49SrJO
ydHnqoA6rOXqc4du+p5c0DhYYrgfVWXCr7QXWZIhoN+L5LQKxWVFTrwoFiW78rmo
HNiLvn2R6z1LASfJJ0ruZy/7Q/ek1et1WAhfGBUdH0OXW8q+xrH6QFp6E8c8Uy8H
YS68Dp4CpK1fLYdQCpNa1A9IAzFuTma+1npwkbWTXCp9sPg8JcBCdMZhdmPVP454
XuP3+zGWXwNMTH0EZrIjl7/SPIEqvLWM4W7aG9rQv4TT+NXwzfU=
=Yd9J
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181021160415.GD13668>