Date: Thu, 23 Feb 2017 12:49:01 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Benjamin Kaduk <bjkfbsd@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r314142 - head/sys/dev/ce Message-ID: <d93f402e-d5f5-03c2-3652-2b6f55987288@FreeBSD.org> In-Reply-To: <CAJ5_RoCw8JEzWybqpsvBm%2BvRUqkVK76zcnvS9omdo79j7QaqTg@mail.gmail.com> References: <201702231530.v1NFULwx024028@repo.freebsd.org> <CAJ5_RoCw8JEzWybqpsvBm%2BvRUqkVK76zcnvS9omdo79j7QaqTg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/23/2017 12:13 PM, Benjamin Kaduk wrote: > On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni <pfg@freebsd.org > <mailto:pfg@freebsd.org>> wrote: > > Author: pfg > Date: Thu Feb 23 15:30:21 2017 > New Revision: 314142 > URL: https://svnweb.freebsd.org/changeset/base/314142 > <https://svnweb.freebsd.org/changeset/base/314142>; > > Log: > dev/ce: double assignment. > > The code is not operational right now so just comment away an > obviously > useless assignment. Fix some typos while here. > > Found with: coccinelle (da.cocci) > > Modified: > head/sys/dev/ce/ceddk.c > > Modified: head/sys/dev/ce/ceddk.c > ============================================================================== > --- head/sys/dev/ce/ceddk.c Thu Feb 23 15:10:46 2017 > (r314141) > +++ head/sys/dev/ce/ceddk.c Thu Feb 23 15:30:21 2017 > (r314142) > @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) > "UserRequest (%s:%d)\n", > __FUNCTION__, __LINE__)); > return; > } > - req->Command = TAU32_Configure_Commit | > - TAU32_Tx_Stop | TAU32_Rx_Stop; > +// req->Command = TAU32_Configure_Commit | > +// TAU32_Tx_Stop | TAU32_Rx_Stop; > > > Should probably stick to C-style comments, though. > They are valid C99 comments but I understand what you mean, OTOH, the code block appears to be so broken, that it doesn't matter. Pedro. > -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d93f402e-d5f5-03c2-3652-2b6f55987288>