Date: Tue, 31 Jan 2017 01:50:57 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 216633] x11/slim: fails to build with clang 4.0 Message-ID: <bug-216633-13-xVFTDYn0wN@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-216633-13@https.bugs.freebsd.org/bugzilla/> References: <bug-216633-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216633 Henry Hu <henry.hu.sh@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179453| |maintainer-approval+ Flags| | --- Comment #1 from Henry Hu <henry.hu.sh@gmail.com> --- Created attachment 179453 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179453&action= =3Dedit patch to fix build I don't have clang 4.0 for now, so I can't test it, but this patch should w= ork. Honestly, I think that this check should be removed. From Xlib.h: /* * Graphics context. The contents of this structure are implementation * dependent. A GC should be treated as opaque by application code. */ XCreateGC's man page does not mention what the return value would be if it failed, and after checking 10 pages of github search results, no one checked the return value of XCreateGC. However, given that GC is a pointer, checking it against NULL should serve = the purpose. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-216633-13-xVFTDYn0wN>