Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Nov 2010 19:53:40 +0100
From:      Gary Jennejohn <gljennjohn@googlemail.com>
To:        freebsd-hackers@freebsd.org
Cc:        Garrett Cooper <gcooper@FreeBSD.org>
Subject:   Re: [PATCH] Simplify uart_bus_pci_probe
Message-ID:  <20101106195340.23caa136@ernst.jennejohn.org>
In-Reply-To: <AANLkTimMt4Ucm%2BfRipzk3sq0M=1DNaC6EGQJ8M0ZWwob@mail.gmail.com>
References:  <AANLkTimMt4Ucm%2BfRipzk3sq0M=1DNaC6EGQJ8M0ZWwob@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 6 Nov 2010 11:22:53 -0700
Garrett Cooper <gcooper@FreeBSD.org> wrote:

>     Some of the logic could have been simplified in the probe. The
> proposed patch makes the detection process a tad bit more
> straightforward.
>     Comments, review (and maybe a commit :P) are more than welcome :).
> Thanks!
> -Garrett

This is definitely much less convoluted and easier to understand than the
old code!

I'd commit it, if I still had my src commit bit :)

--
Gary Jennejohn



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101106195340.23caa136>