Date: Wed, 8 May 2024 14:30:37 +0300 From: Matthias Fechner <mfechner@freebsd.org> To: Antoine Brodin <antoine@freebsd.org>, Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6a6152fcf8c8 - main - textproc/rubygem-nokogiri: Do not install patches Message-ID: <15d6dc83-d207-4c9c-b936-7408d9fa4d7e@freebsd.org> In-Reply-To: <CAALwa8mB_jfk_thF=u0gQs6um1-QyLFt4Gw_P%2B9YjK2=9EimQA@mail.gmail.com> References: <202402211538.41LFcrlW090325@gitrepo.freebsd.org> <CAALwa8mB_jfk_thF=u0gQs6um1-QyLFt4Gw_P%2B9YjK2=9EimQA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------TIcp4J3101wzt8XevzHoQKIJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 06.05.2024 um 11:15 schrieb Antoine Brodin: > This is wrong: > > -- s.add_runtime_dependency(%q<mini_portile2>.freeze, ["~> 2.8.2"]) > > Now, nokogiri depends on mini_portile2 while it shouldn't according > to the comment in the Makefile would it maybe be possible to add mini_portile2 as a runtime dependency? Yes I know that it is maybe not required by FreeBSD, but it is listed upstream: https://rubygems.org/gems/nokogiri and that caused me already some problem that mini_portile2 was missing as some packages expected it (I do not remember the details, but it it took some time to find the reason why). If it does not break anything I suggest we keep as close on the upstream package and do not modify it if not absolutely necessary. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook --------------TIcp4J3101wzt8XevzHoQKIJ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">Am 06.05.2024 um 11:15 schrieb Antoine Brodin:<br> </div> <blockquote type="cite" cite="mid:CAALwa8mB_jfk_thF=u0gQs6um1-QyLFt4Gw_P+9YjK2=9EimQA@mail.gmail.com"> <pre>This is wrong: -- s.add_runtime_dependency(%q<mini_portile2>.freeze, ["~> 2.8.2"]) Now, nokogiri depends on mini_portile2 while it shouldn't according to the comment in the Makefile</pre> </blockquote> <p>would it maybe be possible to add mini_portile2 as a runtime dependency?<br> Yes I know that it is maybe not required by FreeBSD, but it is listed upstream:<br> <a class="moz-txt-link-freetext" href="https://rubygems.org/gems/nokogiri">https://rubygems.org/gems/nokogiri</a><br>; <br> and that caused me already some problem that mini_portile2 was missing as some packages expected it (I do not remember the details, but it it took some time to find the reason why).<br> <br> If it does not break anything I suggest we keep as close on the upstream package and do not modify it if not absolutely necessary.<br> <br> </p> <pre class="moz-signature" cols="72"> Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook </pre> </body> </html> --------------TIcp4J3101wzt8XevzHoQKIJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15d6dc83-d207-4c9c-b936-7408d9fa4d7e>