Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Feb 2009 00:10:21 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r188037 - head/sys/kern
Message-ID:  <200902030010.n130ALGm011551@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Tue Feb  3 00:10:21 2009
New Revision: 188037
URL: http://svn.freebsd.org/changeset/base/188037

Log:
  Declare bus_data_devices to be static: it isn't used elsewhere.
  Use NULL in a couple of places rather than 0 in the context of
  pointers to be consistent with the rest of the file.

Modified:
  head/sys/kern/subr_bus.c

Modified: head/sys/kern/subr_bus.c
==============================================================================
--- head/sys/kern/subr_bus.c	Mon Feb  2 23:04:20 2009	(r188036)
+++ head/sys/kern/subr_bus.c	Tue Feb  3 00:10:21 2009	(r188037)
@@ -741,10 +741,10 @@ sysctl_devctl_disable(SYSCTL_HANDLER_ARG
 
 /* End of /dev/devctl code */
 
-TAILQ_HEAD(,device)	bus_data_devices;
+static TAILQ_HEAD(,device)	bus_data_devices;
 static int bus_data_generation = 1;
 
-kobj_method_t null_methods[] = {
+static kobj_method_t null_methods[] = {
 	{ 0, 0 }
 };
 
@@ -1735,7 +1735,7 @@ device_probe_child(device_t dev, device_
 	driverlink_t best = NULL;
 	driverlink_t dl;
 	int result, pri = 0;
-	int hasclass = (child->devclass != 0);
+	int hasclass = (child->devclass != NULL);
 
 	GIANT_REQUIRED;
 
@@ -2014,7 +2014,7 @@ device_print_prettyname(device_t dev)
 {
 	const char *name = device_get_name(dev);
 
-	if (name == 0)
+	if (name == NULL)
 		return (printf("unknown: "));
 	return (printf("%s%d: ", name, device_get_unit(dev)));
 }
@@ -3842,7 +3842,7 @@ root_bus_module_handler(module_t mod, in
 static moduledata_t root_bus_mod = {
 	"rootbus",
 	root_bus_module_handler,
-	0
+	NULL
 };
 DECLARE_MODULE(rootbus, root_bus_mod, SI_SUB_DRIVERS, SI_ORDER_FIRST);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902030010.n130ALGm011551>