Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Oct 2023 04:11:31 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Cy Schubert <cy@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 4da0d4b17cba - main - sysutils/nut*: Optionally install developer files
Message-ID:  <ZSYgc64IdRN-_PLJ@FreeBSD.org>
In-Reply-To: <202310110252.39B2qIw1032317@gitrepo.freebsd.org>
References:  <202310110252.39B2qIw1032317@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 11, 2023 at 02:52:18AM +0000, Cy Schubert wrote:
> commit 4da0d4b17cba94ae605f3541234a7436d723c170
> 
>   sysutils/nut*: Optionally install developer files
>   
>   Most users do not need files needed for nut development. Make them
>   optional.
...
>  OPTIONS_SUB=	yes

So there's OPTIONS_SUB, right?

> @@ -56,6 +57,7 @@ CGI_DESC=	Web CGI interface
>  FREEIPMI_DESC=	freeipmi support
>  IPMIPSU_DESC=	Use nut-ipmipsu support (experimental)
>  SSL_OFF_DESC=	No SSL support
> +DEV_DESC=	Install developer tools
>  
>  USE_RC_SUBR=	nut nut_upsmon nut_upslog
>  SUB_LIST+=	STATEDIR=${STATEDIR} NUT_USER=${NUT_USER} NUT_GROUP=${NUT_GROUP}
> @@ -134,6 +135,10 @@ OPENSSL_CONFIGURE_WITH=	openssl
>  NSS_LIB_DEPENDS=	libnss3.so:security/nss
>  NSS_CONFIGURE_WITH=	nss
>  
> +DEV_CONFIGURE_WITH=	dev
> +DEV_PLIST_SUB=		DEV=""
> +DEV_PLIST_SUB_OFF=	DEV="@comment "

Then manual PLIST_SUB dances are not needed.  In fact, they'd clash with
existing ones:

$ make -V PLIST_SUB | xargs -n1 | grep DEV=
DEV=@comment
NO_DEV=
DEV=@comment

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZSYgc64IdRN-_PLJ>