Date: Mon, 3 Nov 2008 05:52:43 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r184579 - head/sys/dev/cardbus Message-ID: <200811030552.mA35qhCb057962@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Mon Nov 3 05:52:43 2008 New Revision: 184579 URL: http://svn.freebsd.org/changeset/base/184579 Log: We can't mask out the higher order bits and have the size come out right... Good thing the size was ignored... Where this macro is used, there's no reason to do it anyway. There seems to have been some old-time confusion between the CIS pointer definition, and the BAR definitions at the base of this bug. Modified: head/sys/dev/cardbus/cardbusreg.h Modified: head/sys/dev/cardbus/cardbusreg.h ============================================================================== --- head/sys/dev/cardbus/cardbusreg.h Mon Nov 3 05:19:45 2008 (r184578) +++ head/sys/dev/cardbus/cardbusreg.h Mon Nov 3 05:52:43 2008 (r184579) @@ -45,7 +45,7 @@ #define CARDBUS_EXROM_DATA_CODE_TYPE 0x14 /* Code Type */ #define CARDBUS_EXROM_DATA_INDICATOR 0x15 /* Indicator */ -#define CARDBUS_MAPREG_MEM_ADDR_MASK 0x0ffffff0 +#define CARDBUS_MAPREG_MEM_ADDR_MASK 0xfffffff0 #define CARDBUS_MAPREG_MEM_ADDR(mr) \ ((mr) & CARDBUS_MAPREG_MEM_ADDR_MASK) #define CARDBUS_MAPREG_MEM_SIZE(mr) \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811030552.mA35qhCb057962>