Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Feb 2019 18:23:35 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 235699] Kernel panics when setting IP address if net.link.ether.inet.garp_rexmit_count=2
Message-ID:  <bug-235699-227-GzDj60ywKd@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-235699-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-235699-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235699

Kristof Provost <kp@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress
                 CC|                            |kp@freebsd.org
           Keywords|                            |panic, patch

--- Comment #1 from Kristof Provost <kp@freebsd.org> ---
That looks like another case of CURVNET not being set.

This should fix it:

diff --git a/sys/netinet/if_ether.c b/sys/netinet/if_ether.c
index f278fa1b3ca..c84fcee3328 100644
--- a/sys/netinet/if_ether.c
+++ b/sys/netinet/if_ether.c
@@ -1335,6 +1335,8 @@ garp_rexmit(void *arg)
                return;
        }

+       CURVNET_SET(ia->ia_ifa.ifa_ifp->if_vnet);
+
        /*
         * Drop lock while the ARP request is generated.
         */
@@ -1362,6 +1364,8 @@ garp_rexmit(void *arg)
                        ifa_free(&ia->ia_ifa);
                }
        }
+
+       CURVNET_RESTORE();
 }

 /*

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-235699-227-GzDj60ywKd>