Date: Wed, 23 May 2018 22:55:37 +0000 From: bugzilla-noreply@freebsd.org To: vbox@FreeBSD.org Subject: maintainer-approval requested: [Bug 228433] emulators/virtualbox-ose-kmod: compile error: error: "offsetof is not defined!" : [Attachment 193639] Tantive patch Message-ID: <bug-228433-26505-Z0rka5BHGR@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-228433-26505@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
Guido Falsi <madpilot@FreeBSD.org> has asked vbox@FreeBSD.org for maintainer-approval: Bug 228433: emulators/virtualbox-ose-kmod: compile error: error: "offsetof is not defined!" https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228433 Attachment 193639: Tantive patch https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193639&action=edit --- Comment #1 from Guido Falsi <madpilot@FreeBSD.org> --- Created attachment 193639 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193639&action=edit Tantive patch I've hit this myself just now. Having a look at the failing part of the source code it looks like what they define as a kludge is not necessary anymore and has been fixed in base r324622. I also suspect the kludge was already not necessary when they switched from including stddef.h to including sys/stddef.h, which has never diverged from types.h in the definition of offsetof. I've made a very simple patch removing the kludge and simply including the required files. It does compile, but I still have to test it at runtime, which I will do once building a bunch of other packages is done and report back. I'm anyway attaching my patch for reference.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228433-26505-Z0rka5BHGR>