Date: 27 Jan 1998 16:50:43 +0100 From: dag-erli@ifi.uio.no (Dag-Erling Coidan Smørgrav) To: Mike Smith <mike@smith.net.au> Cc: joelh@gnu.org, hackers@FreeBSD.ORG Subject: Re: File I/O in kernel land (was: Re: 2nd warning: 2.2.6 BETA begins in 10 days!) Message-ID: <xzplnw1kjak.fsf@grjottunagard.ifi.uio.no> In-Reply-To: Mike Smith's message of "Wed, 28 Jan 1998 01:42:49 %2B1030" References: <199801271512.BAA00461@word.smith.net.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Smith <mike@smith.net.au> writes: > 3 establish/disestablish your own timer routine when you are > activated/deactivated (bad again because the remove-saver option > is hidden behind the UNKNOWN_MODE test in scrn_timer()). > > I would actually combine 3 above with moving the "should we stop the > screensaver" test to before the UNKNOWN_MODE bailout in scrn_timer(). After due consideration, I think that's what I'll do. Here's a patch to syscons.c: --- syscons.c.orig Tue Jan 27 16:49:04 1998 +++ syscons.c Tue Jan 27 16:49:53 1998 @@ -2187,17 +2187,17 @@ scintr(0); } + /* should we stop the screen saver? */ + if (mono_time.tv_sec <= scrn_time_stamp + scrn_blank_time) + if (scrn_blanked > 0) + stop_scrn_saver(current_saver); + /* should we just return ? */ if ((scp->status&UNKNOWN_MODE) || blink_in_progress || switch_in_progress) { timeout(scrn_timer, NULL, hz / 10); splx(s); return; } - - /* should we stop the screen saver? */ - if (mono_time.tv_sec <= scrn_time_stamp + scrn_blank_time) - if (scrn_blanked > 0) - stop_scrn_saver(current_saver); if (scrn_blanked <= 0) { /* update screen image */ -- * Finrod (INTJ) * Unix weenie * dag-erli@ifi.uio.no * cellular +47-92835919 * RFC1123: "Be liberal in what you accept, and conservative in what you send"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzplnw1kjak.fsf>