Date: Thu, 6 Aug 2020 12:53:17 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Danilo Eg??a Gondolfo <danilo@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r544245 - head/x11/sakura Message-ID: <20200806125317.GA39512@FreeBSD.org> In-Reply-To: <CAFU7VyOkoJ2yp6Oz88Tfkhts0GzVPDfKXJnyTbfJmmRS0QhcJw@mail.gmail.com> References: <202008052155.075LtmtD072730@repo.freebsd.org> <20200806033440.GA53929@FreeBSD.org> <CAFU7VyOkoJ2yp6Oz88Tfkhts0GzVPDfKXJnyTbfJmmRS0QhcJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 06, 2020 at 11:46:26AM +0100, Danilo Eg??a Gondolfo wrote: > On Thu, Aug 6, 2020 at 4:34 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > > > On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote: > > > New Revision: 544245 > > > URL: https://svnweb.freebsd.org/changeset/ports/544245 > > > > > > @@ -14,9 +14,10 @@ LICENSE= GPLv2 > > > LIB_DEPENDS= libgnutls.so:security/gnutls \ > > > libpcre2-8.so:devel/pcre2 > > > > > > +USES= cmake gnome pkgconfig gettext perl5 tar:bz2 xorg > > > + > > > OPTIONS_DEFINE= DOCS > > > > > > -USES= cmake gnome pkgconfig gettext perl5 xorg > > > USE_GNOME= cairo gdkpixbuf2 vte3 > > > USE_XORG= x11 > > > USE_PERL5= build > > > > I'd argue that USES was placed better before this change (right next to > > USE_FOO knobs). It should've been left where it was and OPTIONS_DEFINE > > moved downwards instead. > > Just tried to make portlint happy on this one ("USES should appear > earlier"). I know why you did this, but it does not make the change less wrong. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200806125317.GA39512>