Date: Tue, 26 Nov 2024 07:54:58 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Stefan =?utf-8?Q?E=C3=9Fer?= <se@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 8ea6c1154094 - main - usr.bin/bc: remove OpenBSD derived bc and dc commands Message-ID: <867c8qcwn1.fsf@ltc.des.dev> In-Reply-To: <4808a71f-a12b-4e70-ad51-a7979f5dff08@FreeBSD.org> ("Stefan =?utf-8?Q?E=C3=9Fer=22's?= message of "Mon, 25 Nov 2024 23:22:22 %2B0100") References: <202411242208.4AOM8WSe033669@gitrepo.freebsd.org> <86r06zcnb7.fsf@ltc.des.dev> <4808a71f-a12b-4e70-ad51-a7979f5dff08@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Stefan E=C3=9Fer <se@FreeBSD.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> writes: >> I appreciate your efforts but this is incomplete, as was pointed out >> in review. > I was not aware that the review was incomplete What did you think the red circle next to my name in Phabricator meant? > Are there any outstanding issues you know about? Yes. For instance, `tools/build/options/WITH_GH_BC` is still present. I pointed this out in Phabricator and marked the review as =E2=80=9Cchanges requested=E2=80=9D on October 2nd, despite your claim in your commit message that I had approved it. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?867c8qcwn1.fsf>