Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Apr 2015 09:04:10 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Bartek Rutkowski <robak@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r383713 - head/www/httpclient
Message-ID:  <20150410090410.GA7905@FreeBSD.org>
In-Reply-To: <201504100858.t3A8whLc068918@svn.freebsd.org>
References:  <201504100858.t3A8whLc068918@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 10, 2015 at 08:58:43AM +0000, Bartek Rutkowski wrote:
> New Revision: 383713
> URL: https://svnweb.freebsd.org/changeset/ports/383713
> 
> Log:
>   www/httpclient: add CPE information
>   
>   - Maintainer's timeout (ale@FreeBSD.org)

We have a standard form for noting maintainer timeouts:

Approved by:	maintainer (ale, timeout [since ...])

> [...] 
> +USES+=	cpe
> +CPE_PRODUCT=	commons-httpclient
> +CPE_VENDOR=	apache
>  RUN_DEPENDS=	${JAVAJARDIR}/httpcore.jar:${PORTSDIR}/www/httpcore \

Wrong indentation of USES value; bogus use of +=; the whole thing should be
placed after *_DEPENDS block (look for USE_JAVA knob).  Admittedly, the
whole Makefile needs some cleaning.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150410090410.GA7905>