Date: Fri, 15 Jul 2016 11:14:37 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302324 - head/lib/libc/locale Message-ID: <20160715091437.lczsxhxffxvp2bq3@ivaldir.etoilebsd.net> In-Reply-To: <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org> References: <201607031500.u63F0Cr8099783@repo.freebsd.org> <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--llh3fvk5woixeh53 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 15, 2016 at 02:19:41AM -0400, Jung-uk Kim wrote: > On 07/03/16 11:00 AM, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sun Jul 3 15:00:12 2016 > > New Revision: 302324 > > URL: https://svnweb.freebsd.org/changeset/base/302324 > >=20 > > Log: > > Fix a bad test resulting in a segfault with ISO-8859-5 locales > > =20 > > Reported by: Lauri Tirkkonen from Illumos > > Approved by: re@ (gjb) > >=20 > > Modified: > > head/lib/libc/locale/collate.c > >=20 > > Modified: head/lib/libc/locale/collate.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libc/locale/collate.c Sun Jul 3 11:45:54 2016 (r302323) > > +++ head/lib/libc/locale/collate.c Sun Jul 3 15:00:12 2016 (r302324) > > @@ -310,7 +310,7 @@ _collate_lookup(struct xlocale_collate * > > if ((sptr =3D *state) !=3D NULL) { > > *pri =3D *sptr; > > sptr++; > > - if ((sptr =3D=3D *state) || (sptr =3D=3D NULL)) > > + if ((sptr =3D=3D *state) || (*sptr =3D=3D 0)) > > *state =3D NULL; > > else > > *state =3D sptr; >=20 > I had a serious regression with ko_KR.UTF-8 locale after this commit. > MATE is unusable because mate-panel is busy looping and eating 100% CPU. > GNOME 3 does not start at all, i.e., nothing but mouse cursor on black > screen. After reverting this commit, everything is back to normal. > Please investigate. IMHO, this must be fixed before 11.0-BETA2 build. >=20 > Thanks, >=20 > Jung-uk Kim >=20 Yes sorry about that, I'm aware of it and working on a fix... Bapt --llh3fvk5woixeh53 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXiKl7AAoJEGOJi9zxtz5aqSUP/A1JRIOh/9sRMU//abPp5vkP RrInAaY3YsfkgUwstXQmy7ImJgT9KPVaWRMu2cJ+NXdQtfpzUVUP8o7LcvRX5F4h /8mlGo4Uv+40OU7Dl2C2ZyRewEj1kyMVdJ/7TEQ+XA52rfUPYUvT8H5YJzQVKhnl GZWgDsEIvs5k7a5ShglKVAto9YmXa09M1mNTDFiwoXG7H63V08pIGa67V/fBc/gb ViEi7xWFduNvYw6c/O0jF/1m8u71nwxxiIiOReScg++qbUXhamZWQnmkSnQqDspN EgyJUeIYK4fEQmu1SHuARV/iM/iR+v6DeW02dI3j/4oHq7a0/5fz6giE1StFZTLb mPl4GhbC6mI/eEhm+gI8TdjszvlKXpFGnj8G60uaHjSSzMhUF0xLnOJAcRNorY3M bzduhF9kASFwgBEstTG20eZl+o5O/RQa+u0/xE9LgQig24lziHch4Dyrkc2U+G/v 9a3dQKjnswJ5cwBfh+lWv9MoeFHQX58NHf+1Yy48YHhXX3RqQ136zA2GHVMcQJer zvasrBMvkxqZOXP4RJDaisokLjBxs4kGAo24Ta9vZf3NL0Z3yU1iOS/pghS33RbD KVffMCXhKh9UoZ/6r0XSFG+e0HS2zEjXo1ZB3F1ou8XB3yKeMxu5Fkm4YEI7S2Gk w+qmHQckWuRbTY9i/wRd =g9c5 -----END PGP SIGNATURE----- --llh3fvk5woixeh53--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160715091437.lczsxhxffxvp2bq3>