Date: Mon, 20 May 2013 16:02:11 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Simon J. Gerraty <sjg@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: svn commit: r250719 - in head: . usr.bin/make Message-ID: <4FEA9E51-475D-494C-83BB-9CBA90990770@gmail.com> In-Reply-To: <201305162126.r4GLQk8Q021290@svn.freebsd.org> References: <201305162126.r4GLQk8Q021290@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 16, 2013, at 2:26 PM, Simon J. Gerraty wrote: > Author: sjg > Date: Thu May 16 21:26:46 2013 > New Revision: 250719 > URL: http://svnweb.freebsd.org/changeset/base/250719 > > Log: > Reverse the sense of the test wrt bmake, and guard against > MK_BMAKE not being defined. I forgot to request this earlier, but could you please document bmake becoming the default system make in UPDATING and some of the associated caveats? It's particularly important to note that set -e is not being implicitly set on the command line (like before) and this is going to potentially confuse some people as cd ; ${MAKE} was the pattern that was done all over the place previously (like we discussed at YOW after BSDCan, stuff where people weren't using set -e and were using semicolons, needs to be fixed in Makefile, Makefile.inc1, etc in order for builds to not silently fail as they will today). Thanks! -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FEA9E51-475D-494C-83BB-9CBA90990770>