Date: Tue, 04 Jan 2011 07:59:55 -0800 From: Colin Percival <cperciva@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216944 - head/sys/i386/xen Message-ID: <4D2343FB.4030402@freebsd.org> In-Reply-To: <201101040800.45155.jhb@freebsd.org> References: <201101040016.p040GcNf010998@svn.freebsd.org> <201101040800.45155.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/04/11 05:00, John Baldwin wrote:
> On Monday, January 03, 2011 7:16:38 pm Colin Percival wrote:
>> +#ifdef INVARIANTS
>> if (__predict_true(gdtset))
>> - critical_enter();
>> + KASSERT(curthread->td_critnest > 0,
>> + ("xen queue flush should be in a critical section"));
>> +#endif
>> +
>
> You can use CRITICAL_ASSERT(curthread) instead perhaps.
Duh. I was looking for that but somehow didn't feed the right keywords to grep.
Thanks!
--
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D2343FB.4030402>