Date: Wed, 03 Jun 2009 18:30:03 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Ed Schouten <ed@80386.nl> Cc: gnome@freebsd.org Subject: Re: [Patch] Build libiconv with USE_CSTD=gnu89 Message-ID: <1244068203.1290.2.camel@shumai.marcuscom.com> In-Reply-To: <20090603221507.GC48776@hoeg.nl> References: <20090603221507.GC48776@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-KKjwU2XBhKx2xoRAq1av Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2009-06-04 at 00:15 +0200, Ed Schouten wrote: > Hi all, >=20 > Pav just added support to the Ports tree to easily specify the C > standard in the port makefiles. Even though the compiler in our base > system uses -std=3Dgnu89 by default, this behaviour could change in the > future. Other compilers (like Clang) already use ISO C99 by default. In > most cases this won't matter, but there are some subtleties. >=20 > One of the ports that really requires the C standard to be set to gnu89, > is libiconv. The problem is that this port uses GNU-style inlining, > which is only enabled when building C89 code. >=20 > I propose the following patch: >=20 > --- converters/libiconv/Makefile > +++ converters/libiconv/Makefile > @@ -17,6 +17,7 @@ > =20 > USE_AUTOTOOLS=3D libtool:15 > GNU_CONFIGURE=3D yes > +USE_CSTD=3D gnu89 > USE_GNOME=3D gnometarget > LIBTOOLFILES=3D configure libcharset/configure > CONFIGURE_ARGS=3D --enable-static \ >=20 > It shouldn't change the behaviour of the port when using GCC, but allows > us Clang folks to build libiconv out of the box. Erwin ran an > experimental ports build with Clang on pointyhat and according to > numbers, libiconv's failure caused it to skip compilation of 9600 other > ports... >=20 > Any comments? I'm fine with this. Feel free to commit. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-KKjwU2XBhKx2xoRAq1av Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkom+WoACgkQb2iPiv4Uz4cMPgCdG0jiIX9yE2lRpC/gcO6yjZGH i7kAniSb+K+vFmruBofy4sfA2E6w601V =jCul -----END PGP SIGNATURE----- --=-KKjwU2XBhKx2xoRAq1av--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1244068203.1290.2.camel>