Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 08 Feb 2004 23:45:13 -0700
From:      Scott Long <scottl@freebsd.org>
To:        Peter Losher <Peter_Losher@isc.org>
Cc:        current@freebsd.org
Subject:   Re: Processes blocked on getblk or ufs
Message-ID:  <40272C79.6040708@freebsd.org>
In-Reply-To: <20040209063331.A11582@farside.isc.org>
References:  <EE3D3FBAFFCAED448C21C398FDAD91AC0108FC@EBE1.gc.nat> <40247AE9.6070805@gddsn.org.cn> <20040207062617.GC49373@teleri.net> <20040209063331.A11582@farside.isc.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------090405000902050808040707
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Peter Losher wrote:
> On Sat, 7 Feb 2004, Chip Norkus wrote:
> 
> 
>>>woo,  Scott's commit seem to fix this problem for me!
>>>
>>
>>I think I can throw a 'me too' in here.  A build (make -j8 world) which
>>would reliably lock up one of my 2650s no longer does so.  This is
>>extremely encouraging. :)  Thanks so much for the hard work on this!
> 
> 
> Any chance this can be backported to RELENG_5_2?  Because as it is now 5.2
> is unusable on Dell systems using the aac driver.
> 
> -Peter

Can you try the attached patch?

Scott

--------------090405000902050808040707
Content-Type: text/plain;
 name="aac_unmap.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="aac_unmap.diff"

Index: aac.c
===================================================================
RCS file: /usr/ncvs/src/sys/dev/aac/aac.c,v
retrieving revision 1.81
diff -u -r1.81 aac.c
--- aac.c	9 Nov 2003 09:17:20 -0000	1.81
+++ aac.c	9 Feb 2004 06:41:57 -0000
@@ -1290,8 +1290,10 @@
 	cm->cm_flags |= AAC_CMD_MAPPED;
 
 	/* put the FIB on the outbound queue */
-	if (aac_enqueue_fib(sc, cm->cm_queue, cm) == EBUSY)
+	if (aac_enqueue_fib(sc, cm->cm_queue, cm) == EBUSY) {
+		aac_unmap_command(cm);
 		aac_requeue_ready(cm);
+	}
 
 	return;
 }

--------------090405000902050808040707--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40272C79.6040708>