Date: Sat, 01 Dec 2018 21:38:17 +0000 From: bugzilla-noreply@freebsd.org To: powerpc@FreeBSD.org Subject: [Bug 233693] [PowerPC64] Powerd unable to change cpu frequency Message-ID: <bug-233693-25139-4OIrpptBAV@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233693-25139@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233693 --- Comment #10 from commit-hook@freebsd.org --- A commit references this bug: Author: cem Date: Sat Dec 1 21:37:47 UTC 2018 New revision: 341389 URL: https://svnweb.freebsd.org/changeset/base/341389 Log: pmcr: Fix pstate setting on Power8 Fix p-state setting on Power8 by removing the accidental double-indirection of the pstate_ids table. The pstate_ids table comes from the OF property "ibm,pstate-ids." On Power9, the values happen to be identical to the indices, so the extra indirection was harmless. On Power8, the values were out of the range [0, npstates], so pmcr_set() would fail the spec[0] range check with EINVAL. While here, include both the value and index in the driver-specific register array as spec[0] and spec[1] respectively. They're redundant, but relatively harmless, and it may aid debugging. While here, fix the range check to exclude the index npstates, which is one past the last valid index. PR: 233693 Reported and tested by: sbruno Reviewed by: jhibbits Changes: head/sys/powerpc/cpufreq/pmcr.c -- You are receiving this mail because: You are on the CC list for the bug.help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233693-25139-4OIrpptBAV>