Date: Sat, 21 May 2016 13:33:36 +0200 From: John Marino <freebsd.contact@marino.st> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Ed Maste <emaste@freebsd.org> Cc: Baptiste Daroussin <bapt@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r415078 - in head: . Mk Message-ID: <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st> In-Reply-To: <20160521112728.GA624@FreeBSD.org> References: <201605121820.u4CIKROJ004026@repo.freebsd.org> <20160513160151.GA30219@FreeBSD.org> <20160513182837.GF49383@ivaldir.etoilebsd.net> <20160513201919.GA48945@FreeBSD.org> <CAPyFy2A9L1cCikOrgBAWUo0GTCLJ4EgzqukhobaJp%2BZqv7_SpQ@mail.gmail.com> <20160519122306.GA24015@FreeBSD.org> <20160521112728.GA624@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/21/2016 1:27 PM, Alexey Dokuchaev wrote:
> On Thu, May 19, 2016 at 12:23:06PM +0000, Alexey Dokuchaev wrote:
>> ...
>> I'm still not convinced though, sorry. Ports tree can be obtained by
>> a number of means, but this new ugly TIMESTAMP thingy is added for a
>> very specific usecase, and there should be no problem to require that
>> for that particular usecase, exported ports tree must have its files'
>> mtimes correctly set. (If svn/git/hg are not setting right mtimes on
>> export, they should be fixed.) It looks more like quick'n'dirty hack
>> rather than thoroughly thought-out solution.
>
> Given lack of replies, I guess I'd have to elaborate a bit on problems with
> TIMESTAMP and why I'm against it.
>
> 1. It does not line up with distinfo format. This file contains certain
> properties for each distfile a port requires, namely SIZE() and SHA256(),
> which are used to verify their integrity. Notice that distinfo may list
> several distfiles, and both SIZE() and SHA256() are essentially functions
> of a particular distfile.
>
> Introducing TIMESTAMP breaks this logic, as it's not attached to anything.
> Which distfile does it refer to? If it supposed to be bumped every time
> distinfo changes, why not simply use max(m in mtime(distfiles)) if there
> is (or rather, you *believe* there is) a problem with mtime(distinfo)?
>
> 2. It is not needed even if ports repo is obtained as tarball: svn/git/hg
> all correctly set mtimes on files ("svn export", "hg/git archive"). If
> users are tarring their checked out copy they're doing it wrong and should
> be instructed how to export repositories correctly.
>
> Putting TIMESTAMP might be easier than writing proper documentation, but
> that's not an excuse good enough for FreeBSD. Please reconsider.
Maybe it could/should be implemented as a makefile variable instead?
e.g. REP_TIMESTAMP=
Just a suggestion. I don't disagree with you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?364d3d9f-63ff-18c8-c730-a11c57dc0673>