Date: Tue, 6 Feb 2024 23:05:27 +0100 From: tuexen@freebsd.org To: Michael Tuexen <tuexen@freebsd.org> Cc: "Herbert J. Skuhra" <herbert@gojira.at>, current@freebsd.org, net@freebsd.org Subject: Re: Request for Testing: TCP RACK Message-ID: <1283FF33-4A2B-4895-926D-5593684C3211@freebsd.org> In-Reply-To: <E48CE1B7-EC42-4D33-93F7-FAE3D22786A2@freebsd.org> References: <42C327BD-6CE4-43AA-A1AE-3BEC08D623DB@freebsd.org> <87pm09ykb8.wl-herbert@gojira.at> <87o7ftyhkp.wl-herbert@gojira.at> <CA%2Bq%2BTcoU21yisYDuCkYtAkJE-WXLdtohZi893zMP%2BNMG0WUh3Q@mail.gmail.com> <87msvdy0v4.wl-herbert@gojira.at> <867DC224-F0B1-4C9C-8EB7-C9F7BE1C029A@freebsd.org> <87edgo33s9.wl-herbert@gojira.at> <87o7e1s7oc.wl-herbert@gojira.at> <87le95rnp8.wl-herbert@gojira.at> <99432C3E-6AD0-4B1B-9E50-C455D397861B@freebsd.org> <87jzoosuie.wl-herbert@gojira.at> <E48CE1B7-EC42-4D33-93F7-FAE3D22786A2@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 5, 2024, at 08:48, tuexen@freebsd.org wrote: >=20 >> On Jan 4, 2024, at 21:39, Herbert J. Skuhra <herbert@gojira.at> = wrote: >>=20 >> On Thu, 04 Jan 2024 21:22:22 +0100, tuexen@freebsd.org wrote: >>>=20 >>>> On Jan 4, 2024, at 18:52, Herbert J. Skuhra <herbert@gojira.at> = wrote: >>>>=20 >>>> On Thu, 04 Jan 2024 11:40:35 +0100, "Herbert J. Skuhra" wrote: >>>>>=20 >>>>> On Fri, 17 Nov 2023 14:31:02 +0100, "Herbert J. Skuhra" wrote: >>>>>>=20 >>>>>> Hi, >>>>>>=20 >>>>>> On Fri, 17 Nov 2023 00:15:13 +0100, tuexen@freebsd.org wrote: >>>>>>>=20 >>>>>>>> On Nov 16, 2023, at 20:06, Herbert J. Skuhra = <herbert@gojira.at> wrote: >>>>>>>>=20 >>>>>>>> On Thu, 16 Nov 2023 19:07:29 +0100, Olivier Cochard-Labb=C3=A9 = wrote: >>>>>>>>>=20 >>>>>>>>> On Thu, Nov 16, 2023 at 5:10=E2=80=AFPM Herbert J. Skuhra = <herbert@gojira.at> wrote: >>>>>>>>>=20 >>>>>>>>>>=20 >>>>>>>>>> OK, I am now running GENERIC-NODEBUG + "options TCPHPTS". >>>>>>>>>>=20 >>>>>>>>>> After setting "sysctl net.inet.tcp.functions_default=3Drack" = git no >>>>>>>>>> longer works: >>>>>>>>>>=20 >>>>>>>>>>=20 >>>>>>>>> Are you using a fresh 15 head or a specific network setup ? >>>>>>>>>=20 >>>>>>>>> Because I'm not able to reproduce your problem on my system: >>>>>>>>>=20 >>>>>>>>> $ uname -a >>>>>>>>> FreeBSD bigone 15.0-CURRENT FreeBSD 15.0-CURRENT #0 >>>>>>>>> main-n266452-070d9e3540e6: Thu Nov 16 17:53:15 CET 2023 >>>>>>>>> root@bigone:/usr/obj/usr/src/amd64.amd64/sys/TCPHPTS >>>>>>>>> amd64 >>>>>>>>> $ cat /usr/src/sys/amd64/conf/TCPHPTS >>>>>>>>> include GENERIC-NODEBUG >>>>>>>>> ident TCPHPTS >>>>>>>>> options TCPHPTS >>>>>>>>> $ sysctl net.inet.tcp.functions_default >>>>>>>>> net.inet.tcp.functions_default: rack >>>>>>>>> $ git clone -q git@github.com:freebsd/freebsd-src.git && echo = working >>>>>>>>> working >>>>>>>>> $ >>>>>>>>=20 >>>>>>>> OK, (g)it works if I disable pf. Do you use pf? >>>>>>> Can you share your pf config such that I can reproduce the = problem locally? >>>>>>=20 >>>>>> 1. It even fails with a simple pf.conf: >>>>>> pass in all >>>>>> pass out all >>>>>>=20 >>>>>> 2. Fetching port distfiles also failed. >>>>>>=20 >>>>>> 3. If I disable rxcsum on the ethernet adapter (igb0) it works. >>>>>=20 >>>>> Disabling lro also resolves the issue. >>>>=20 >>>> If I run "sysctl net.inet.tcp.rack.features.cmpack=3D0" I don't = have to >>>> disable rxcsum/tcxsum or lro on igb0. >>> Does the problem also goes away if you disable pf completely, but = keep >>> compressed acks enabled? >>=20 >> Yes, it works with pf disabled and compressed acks enabled. > Thanks for the information! A patch is available at: https://reviews.freebsd.org/D43769 Best regards Michael >=20 > Best regards > Michael >>=20 >> -- >> Herbert >=20 >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1283FF33-4A2B-4895-926D-5593684C3211>