Date: Sat, 18 Oct 2003 12:13:09 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/fs/nwfs nwfs_vnops.c src/sys/fs/smbfs smbfs_vnops.c Message-ID: <20031018121152.V47115@root.org> In-Reply-To: <20031018093315.22C3C16A554@hub.freebsd.org> References: <20031018093315.22C3C16A554@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 18 Oct 2003, Poul-Henning Kamp wrote:
> Modified files:
> sys/kern vfs_bio.c
> sys/fs/nwfs nwfs_vnops.c
> sys/fs/smbfs smbfs_vnops.c
> Log:
> Convert some if(bla) panic("foo") to KASSERTS to improve grep-ability.
>
> Revision Changes Path
> 1.29 +1 -2 src/sys/fs/nwfs/nwfs_vnops.c
> 1.41 +1 -2 src/sys/fs/smbfs/smbfs_vnops.c
> 1.414 +2 -4 src/sys/kern/vfs_bio.c
>
>
> Index: src/sys/fs/nwfs/nwfs_vnops.c
> diff -u src/sys/fs/nwfs/nwfs_vnops.c:1.28 src/sys/fs/nwfs/nwfs_vnops.c:1.29
> --- src/sys/fs/nwfs/nwfs_vnops.c:1.28 Sun Jun 15 11:52:58 2003
> +++ src/sys/fs/nwfs/nwfs_vnops.c Sat Oct 18 02:32:39 2003
> @@ -799,8 +799,7 @@
> KASSERT(ap->a_vp == ap->a_bp->b_vp, ("%s(%p != %p)",
> __func__, ap->a_vp, ap->a_bp->b_vp));
> NCPVNDEBUG("\n");
> - if (bp->b_flags & B_PHYS)
> - panic("nwfs physio");
> + KASSERT(!(bp->b_flags & B_PHYS), ("nwfs physio"));
> if (bp->b_flags & B_ASYNC)
> td = (struct thread *)0;
> else
This removes sanity checks for the !INVARIANTS case (which all our
releases are).
-Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031018121152.V47115>