Date: Fri, 24 May 2019 17:38:24 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Steven Hartland <steven.hartland@multiplay.co.uk>, Conrad Meyer <cem@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r348255 - head/sys/kern Message-ID: <003FD1FE-C765-4873-A784-D743F6A2156C@cschubert.com> In-Reply-To: <CAHEMsqZ_d8Q8tWiG_Zn%2BdL7uDGPKLGBxn9aUMBmGPe3RwcTQ7w@mail.gmail.com> References: <201905242233.x4OMXEAr071844@repo.freebsd.org> <CAHEMsqZ_d8Q8tWiG_Zn%2BdL7uDGPKLGBxn9aUMBmGPe3RwcTQ7w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
+1 -------- Original Message -------- From: Steven Hartland <steven=2Ehartland@multiplay=2Eco=2Euk> Sent: May 24, 2019 4:21:39 PM PDT To: Conrad Meyer <cem@freebsd=2Eorg> Cc: src-committers@freebsd=2Eorg, svn-src-all@freebsd=2Eorg, svn-src-head@= freebsd=2Eorg Subject: Re: svn commit: r348255 - head/sys/kern Just wanted to say I really appreciate the details in this commit message= =2E Its often the case the message get overlooked when it comes to the time needed to write a truly useful message to others and this a great example of the quality we should all try to follow=2E Regards Steve On Fri, 24 May 2019 at 23:33, Conrad Meyer <cem@freebsd=2Eorg> wrote: > Author: cem > Date: Fri May 24 22:33:14 2019 > New Revision: 348255 > URL: https://svnweb=2Efreebsd=2Eorg/changeset/base/348255 > > Log: > Disable intr_storm_threshold mechanism by default > > The ixl=2E4 manual page has documented that the threshold falsely dete= cts > interrupt storms on 40Gbit NICs as long ago as 2015, and we have seen > similar false positives with the ioat(4) DMA device (which can push > GB/s)=2E > > For example, synthetic load can be generated with tools/tools/ioat > 'ioatcontrol 0 200 8192 1 1000' (allocate 200x8kB buffers, generate an > interrupt for each one, and do this for 1000 milliseconds)=2E With > storm-detection disabled, the Broadwell-EP version of this device is > capable > of generating ~350k real interrupts per second=2E > > The following historical context comes from jhb@: Originally, the > threshold > worked around incorrect routing of PCI INTx interrupts on single-CPU > systems > which would end up in a hard hang during boot=2E Since the threshold = was > added, our PCI interrupt routing was improved, most PCI interrupts use > edge-triggered MSI instead of level-triggered INTx, and typical system= s > have > multiple CPUs available to service interrupts=2E > > On the off chance that the threshold is useful in the future, it remai= ns > available as a tunable and sysctl=2E > > Reviewed by: jhb > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews=2Efreebsd=2Eorg/D20401 > > Modified: > head/sys/kern/kern_intr=2Ec > > Modified: head/sys/kern/kern_intr=2Ec > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/kern_intr=2Ec Fri May 24 22:30:40 2019 (r3482= 54) > +++ head/sys/kern/kern_intr=2Ec Fri May 24 22:33:14 2019 (r3482= 55) > @@ -91,7 +91,7 @@ struct proc *intrproc; > > static MALLOC_DEFINE(M_ITHREAD, "ithread", "Interrupt Threads"); > > -static int intr_storm_threshold =3D 1000; > +static int intr_storm_threshold =3D 0; > SYSCTL_INT(_hw, OID_AUTO, intr_storm_threshold, CTLFLAG_RWTUN, > &intr_storm_threshold, 0, > "Number of consecutive interrupts before storm protection is > enabled"); > > --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert <Cy=2ESchubert@cschubert=2Ecom> FreeBSD UNIX: <cy@FreeBSD=2Eorg> Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E From owner-svn-src-all@freebsd.org Sat May 25 01:58:02 2019 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F0CC315BA64E; Sat, 25 May 2019 01:58:01 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9347988CAB; Sat, 25 May 2019 01:58:01 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 547D82562A; Sat, 25 May 2019 01:58:01 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x4P1w1Es077029; Sat, 25 May 2019 01:58:01 GMT (envelope-from delphij@FreeBSD.org) Received: (from delphij@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x4P1w0L6077023; Sat, 25 May 2019 01:58:00 GMT (envelope-from delphij@FreeBSD.org) Message-Id: <201905250158.x4P1w0L6077023@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: delphij set sender to delphij@FreeBSD.org using -f From: Xin LI <delphij@FreeBSD.org> Date: Sat, 25 May 2019 01:58:00 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r348261 - in stable/11: contrib/zlib lib/libz stand/libsa usr.bin/minigzip X-SVN-Group: stable-11 X-SVN-Commit-Author: delphij X-SVN-Commit-Paths: in stable/11: contrib/zlib lib/libz stand/libsa usr.bin/minigzip X-SVN-Commit-Revision: 348261 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9347988CAB X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>; List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 25 May 2019 01:58:02 -0000 Author: delphij Date: Sat May 25 01:58:00 2019 New Revision: 348261 URL: https://svnweb.freebsd.org/changeset/base/348261 Log: MFC r347244: Move contrib/zlib to sys/contrib/zlib so that we can use it in kernel. This is a prerequisite of unifying kernel zlib instances. Submitted by: Yoshihiro Ota <ota at j.email.ne.jp> Approved by: re (kib) Added: - copied from r347244, head/sys/contrib/zlib/ Directory Properties: stable/11/sys/contrib/zlib/ (props changed) Deleted: stable/11/contrib/zlib/ Modified: stable/11/lib/libz/FREEBSD-upgrade stable/11/lib/libz/Makefile stable/11/stand/libsa/Makefile stable/11/usr.bin/minigzip/Makefile Directory Properties: stable/11/ (props changed) Modified: stable/11/lib/libz/FREEBSD-upgrade ============================================================================== --- stable/11/lib/libz/FREEBSD-upgrade Sat May 25 00:22:07 2019 (r348260) +++ stable/11/lib/libz/FREEBSD-upgrade Sat May 25 01:58:00 2019 (r348261) @@ -8,7 +8,7 @@ benefit other consumers. To Update: 1) Unpack vendor sources into a clean directory. 2) Import onto the vendor area. - 3) Merge the vendor tree to contrib/zlib, which contains a stripped down + 3) Merge the vendor tree to sys/contrib/zlib, which contains a stripped down version of upstream source, resolve any conflicts. 4) Double check zconf.h, zlib.pc, and Symbol.map to make sure that we have the required changes. Test universe and commit them. Modified: stable/11/lib/libz/Makefile ============================================================================== --- stable/11/lib/libz/Makefile Sat May 25 00:22:07 2019 (r348260) +++ stable/11/lib/libz/Makefile Sat May 25 01:58:00 2019 (r348261) @@ -8,7 +8,7 @@ SHLIBDIR?= /lib SHLIB_MAJOR= 6 MAN= zlib.3 zopen.3 -ZLIBSRC= ${SRCTOP}/contrib/zlib +ZLIBSRC= ${SRCTOP}/sys/contrib/zlib .PATH: ${ZLIBSRC} Modified: stable/11/stand/libsa/Makefile ============================================================================== --- stable/11/stand/libsa/Makefile Sat May 25 00:22:07 2019 (r348260) +++ stable/11/stand/libsa/Makefile Sat May 25 01:58:00 2019 (r348261) @@ -99,8 +99,8 @@ CFLAGS+= -DBZ_NO_STDIO -DBZ_NO_COMPRESS SRCS+=bzlib.c crctable.c decompress.c huffman.c randtable.c # decompression functionality from zlib -.PATH: ${SRCTOP}/contrib/zlib -CFLAGS+=-DHAVE_MEMCPY -I${SRCTOP}/contrib/zlib +.PATH: ${SRCTOP}/sys/contrib/zlib +CFLAGS+=-DHAVE_MEMCPY -I${SRCTOP}/sys/contrib/zlib SRCS+= adler32.c crc32.c SRCS+= infback.c inffast.c inflate.c inftrees.c zutil.c Modified: stable/11/usr.bin/minigzip/Makefile ============================================================================== --- stable/11/usr.bin/minigzip/Makefile Sat May 25 00:22:07 2019 (r348260) +++ stable/11/usr.bin/minigzip/Makefile Sat May 25 01:58:00 2019 (r348261) @@ -1,6 +1,6 @@ # $FreeBSD$ -SRCDIR= ${SRCTOP}/contrib/zlib/test +SRCDIR= ${SRCTOP}/sys/contrib/zlib/test .PATH: ${SRCDIR} PROG= minigzip
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?003FD1FE-C765-4873-A784-D743F6A2156C>