Date: Fri, 7 Oct 2011 06:14:55 -0600 From: "Kenneth D. Merry" <ken@FreeBSD.org> To: bf1783@gmail.com Cc: ports@FreeBSD.org, danfe@FreeBSD.org, multimedia@FreeBSD.org Subject: Re: audio/cdparanoia broken on -CURRENT, and probably on 9.0 Message-ID: <20111007121455.GA39154@nargothrond.kdm.org> In-Reply-To: <20111007121113.GA36879@nargothrond.kdm.org> References: <CAGFTUwOXZ2sCf_nMUatjjPdC0XnVn%2BZ9DyYnwtOnUrS1nUS=tg@mail.gmail.com> <20111007121113.GA36879@nargothrond.kdm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 07, 2011 at 06:11:13 -0600, Kenneth D. Merry wrote: > On Fri, Oct 07, 2011 at 03:46:22 -0400, b. f. wrote: > > Just a note to say that recent changes on -CURRENT (r225950, meaning > > that it is probably broken on 9.0 after r226067) have broken > > audio/cdparanoia, and it should be fixed or marked as BROKEN there. I > > haven't filed a PR, or attempted to patch it yet -- I think that it > > would be worthwhile to look into moving to 10.2, which has a large > > number of improvements, although suffering from some Linuxisms. > > This will be easy to patch, using one of two methods: > > - change struct scsi_sense_data to struct scsi_sense_data_fixed > or, better yet: > - use scsi_extract_sense_len(), which will work for fixed or descriptor > sense. I should have also mentioned that this should be dependent on CAM_VERSION >= 0x16. Ken -- Kenneth Merry ken@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111007121455.GA39154>