Date: Sat, 21 Jan 2012 19:43:38 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Rui Paulo <rpaulo@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230408 - head/sys/net80211 Message-ID: <CAJ-Vmo=xGSoikK7WYbpLV=JausODdoMRdX4MntLO6-AC9Huu2g@mail.gmail.com> In-Reply-To: <F190251F-A479-43DD-990C-64FDB501162F@FreeBSD.org> References: <201201210038.q0L0cJac066145@svn.freebsd.org> <F190251F-A479-43DD-990C-64FDB501162F@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 January 2012 18:41, Rui Paulo <rpaulo@freebsd.org> wrote: > This commit doesn't help much and keeps us more toolchain dependent like > Alexander pointed out in IRC. Since ether_sprintf() wasn't causing any > trouble, please consider backing this out. > > This commit also introduces unnecessary changes which make reviewing > harder. > Hi, I'd like to eventually move away from doing it this way. The trouble is using ether_sprintf() multiple times (and even from multiple threads?) in the same debug statement results in non-useful behaviour. What I'm likely going to do is introduce an ether_ssprintf() which takes a char/len buffer to write into. That way the debug statements can just use that (with appropriate wrappers around them to only call ether_ssprintf() if the debug condition is met, otherwise unused sprintf()s will occur. I'm open to other suggestions though! Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=xGSoikK7WYbpLV=JausODdoMRdX4MntLO6-AC9Huu2g>