Date: Sun, 31 Jul 2016 22:28:38 -0700 From: Xin Li <delphij@delphij.net> To: "Pedro F. Giffuni" <pfg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net Subject: Re: svn commit: r303600 - head/usr.bin/indent Message-ID: <8d6114b7-cd71-239a-dcc4-03a6d568482c@delphij.net> In-Reply-To: <201607312136.u6VLaeRb058693@repo.freebsd.org> References: <201607312136.u6VLaeRb058693@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ibkdQuaLo4iB7j34Ll0K30K4it8V0osip Content-Type: multipart/mixed; boundary="ow1a1EjppvvOJkjtFv0l3dEfG3XLHDJMw" From: Xin Li <delphij@delphij.net> To: "Pedro F. Giffuni" <pfg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net Message-ID: <8d6114b7-cd71-239a-dcc4-03a6d568482c@delphij.net> Subject: Re: svn commit: r303600 - head/usr.bin/indent References: <201607312136.u6VLaeRb058693@repo.freebsd.org> In-Reply-To: <201607312136.u6VLaeRb058693@repo.freebsd.org> --ow1a1EjppvvOJkjtFv0l3dEfG3XLHDJMw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 7/31/16 14:36, Pedro F. Giffuni wrote: > Author: pfg > Date: Sun Jul 31 21:36:40 2016 > New Revision: 303600 > URL: https://svnweb.freebsd.org/changeset/base/303600 >=20 > Log: > indent(1): replace function call to bzero with memset. > =20 > Reference: > https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833= d7106035dc09230235 > =20 > Differential Revision: https://reviews.freebsd.org/D6966 (Partial) > Submitted by: Piotr Stefaniak >=20 > Modified: > head/usr.bin/indent/io.c >=20 > Modified: head/usr.bin/indent/io.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/indent/io.c Sun Jul 31 21:29:10 2016 (r303599) > +++ head/usr.bin/indent/io.c Sun Jul 31 21:36:40 2016 (r303600) > @@ -629,7 +629,7 @@ parsefont(struct fstate *f, const char * > const char *s =3D s0; > int sizedelta =3D 0; > =20 > - bzero(f, sizeof *f); > + memset(f, 0, sizeof(struct fstate)); ^^^^^^^^^^^^^^^^^^^^^ This is much more error-prone than sizeof(*f) IMHO. Cheers, --ow1a1EjppvvOJkjtFv0l3dEfG3XLHDJMw-- --ibkdQuaLo4iB7j34Ll0K30K4it8V0osip Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJXnt4KAAoJEJW2GBstM+ns71oP+wZGaoyh1/leHqlrQ1ZGY66e PO0RWY+AZQBNqgoqvklQnv3UkPdkwHw19Or0QTziyRaG+PNpf4fZ7WRO53ycO2Ne AsdsjiIZpier2GfjOjSb25hQzc7Qt9tOYm3rNCUyaB9JndJKALcEq0cZczbRuqIk 6dwbqPXk91BkuNIbU78jtPkX0NNa9zBYRcTA8jqxQirn5HX/pVcA7WiIWF3azq9Q q43vNTY4J3+Pxsh0Hyekew/7UA1yI7oSkNy3MiQcYmua1Ag6rGnELGdh3kXJPXBG PCLXhK15BYFBM5RMP8z2ZR/VfIJSc2bsvpoA+uiut9U2PdaTgS3gj6rM5z3ZvCrz Sm08SwP2FvnhqqmXEu/gyxt2kDhQYb4gXVSl4GzeJU+FsEiHXfvw+svNDYlXUVwy qiEbXr4naXK+z6VdETgS2VTP1XmI1hHSy9K0d5r8jJOfhTIjvDroKp55NB5Adov8 80DvtNH/Ymic2RD2FHgsW4sh9RYeYSPlEssEfT5axJwuFIVwixD+K2ong8zInIMr KnnNWAek/XoAqPEQoJzjp81tFp5iLqOaTjVDxMIZBTGuSHfp0qFqgpRRom0wo8A0 +va5exdLtcQlHfyRyeH3qDWSoajNuSv+NJerVQBONTwYy8MlAMP5/v/jETtFb6e+ +WcboMomhRJ97Wm5Vn8M =orQq -----END PGP SIGNATURE----- --ibkdQuaLo4iB7j34Ll0K30K4it8V0osip--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8d6114b7-cd71-239a-dcc4-03a6d568482c>