Date: Tue, 7 Nov 2006 00:09:12 +0100 From: Olivier Houchard <cognet@ci0.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libstand Makefile src/lib/libc/amd64/net Makefile.inc htonl.S htons.S ntohl.S ntohs.S src/lib/libc/arm/net htonl.S htons.S ntohl.S ntohs.S src/lib/libc/i386/net Makefile.inc htonl.S htons.S ntohl.S ntohs.S src/lib/libc/ia64/net Makefile.inc ... Message-ID: <20061106230912.GA66407@ci0.org> In-Reply-To: <454FBA57.5000700@FreeBSD.org> References: <200611062207.kA6M7lqf023545@repoman.freebsd.org> <454FBA57.5000700@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 06, 2006 at 02:42:31PM -0800, Maxim Sobolev wrote: > Does it have any performance implications? Just curious. > > -Maxim > It shouldn't be. Most of the applications already use the version in <machine/endian.h> anyway, because that's what you get when you include <netinet/in.h>. Those are here because the symbols have to be in the libc. Cheers, Olivier > Olivier Houchard wrote: > >cognet 2006-11-06 22:07:47 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libstand Makefile > > lib/libc/net Makefile.inc > > Added files: > > lib/libc/net ntoh.c > > Removed files: > > lib/libc/amd64/net Makefile.inc htonl.S htons.S ntohl.S > > ntohs.S > > lib/libc/arm/net htonl.S htons.S ntohl.S ntohs.S > > lib/libc/i386/net Makefile.inc htonl.S htons.S ntohl.S > > ntohs.S > > lib/libc/ia64/net Makefile.inc byte_swap_2.S byte_swap_4.S > > htonl.S htons.S ntohl.S ntohs.S > > lib/libc/powerpc/net Makefile.inc htonl.S htons.S ntohl.S > > ntohs.S > > lib/libc/sparc64/net Makefile.inc htonl.S htons.S ntohl.S > > ntohs.S > > Log: > > Instead of re-implementing hton[ls] and friends for each arch, add a new > > MI > > file, net/ntoh.c, which just implement them using the inline functions > > from > > <sys/endian.h>. > > > > Suggested by: bde > > > > Revision Changes Path > > 1.7 +0 -4 src/lib/libc/amd64/net/Makefile.inc (dead) > > 1.11 +0 -50 src/lib/libc/amd64/net/htonl.S (dead) > > 1.11 +0 -50 src/lib/libc/amd64/net/htons.S (dead) > > 1.11 +0 -50 src/lib/libc/amd64/net/ntohl.S (dead) > > 1.11 +0 -52 src/lib/libc/amd64/net/ntohs.S (dead) > > 1.3 +0 -50 src/lib/libc/arm/net/htonl.S (dead) > > 1.3 +0 -49 src/lib/libc/arm/net/htons.S (dead) > > 1.3 +0 -50 src/lib/libc/arm/net/ntohl.S (dead) > > 1.3 +0 -49 src/lib/libc/arm/net/ntohs.S (dead) > > 1.7 +0 -4 src/lib/libc/i386/net/Makefile.inc (dead) > > 1.12 +0 -50 src/lib/libc/i386/net/htonl.S (dead) > > 1.10 +0 -50 src/lib/libc/i386/net/htons.S (dead) > > 1.12 +0 -50 src/lib/libc/i386/net/ntohl.S (dead) > > 1.10 +0 -52 src/lib/libc/i386/net/ntohs.S (dead) > > 1.2 +0 -3 src/lib/libc/ia64/net/Makefile.inc (dead) > > 1.6 +0 -48 src/lib/libc/ia64/net/byte_swap_2.S (dead) > > 1.6 +0 -48 src/lib/libc/ia64/net/byte_swap_4.S (dead) > > 1.5 +0 -36 src/lib/libc/ia64/net/htonl.S (dead) > > 1.5 +0 -36 src/lib/libc/ia64/net/htons.S (dead) > > 1.5 +0 -36 src/lib/libc/ia64/net/ntohl.S (dead) > > 1.5 +0 -36 src/lib/libc/ia64/net/ntohs.S (dead) > > 1.62 +3 -8 src/lib/libc/net/Makefile.inc > > 1.1 +58 -0 src/lib/libc/net/ntoh.c (new) > > 1.2 +0 -4 src/lib/libc/powerpc/net/Makefile.inc (dead) > > 1.2 +0 -38 src/lib/libc/powerpc/net/htonl.S (dead) > > 1.2 +0 -38 src/lib/libc/powerpc/net/htons.S (dead) > > 1.2 +0 -38 src/lib/libc/powerpc/net/ntohl.S (dead) > > 1.2 +0 -40 src/lib/libc/powerpc/net/ntohs.S (dead) > > 1.3 +0 -3 src/lib/libc/sparc64/net/Makefile.inc (dead) > > 1.5 +0 -56 src/lib/libc/sparc64/net/htonl.S (dead) > > 1.4 +0 -58 src/lib/libc/sparc64/net/htons.S (dead) > > 1.5 +0 -56 src/lib/libc/sparc64/net/ntohl.S (dead) > > 1.4 +0 -58 src/lib/libc/sparc64/net/ntohs.S (dead) > > 1.57 +3 -7 src/lib/libstand/Makefile > > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061106230912.GA66407>