Date: Fri, 25 Feb 2005 11:39:05 -0800 From: Sam Leffler <sam@errno.com> To: src-committers@FreeBSD.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/svr4 svr4_signal.c svr4_signal.h svr4_sysvec.c Message-ID: <421F7ED9.9050009@errno.com> In-Reply-To: <200502251934.j1PJYBQf002457@repoman.freebsd.org> References: <200502251934.j1PJYBQf002457@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sam Leffler wrote: > sam 2005-02-25 19:34:11 UTC > > FreeBSD src repository > > Modified files: > sys/compat/svr4 svr4_signal.c svr4_signal.h svr4_sysvec.c > Log: > fixup signal mapping: > o change the mapping arrays to have a zero offset rather than base 1; > this eliminates lots of signo adjustments and brings the code > back inline with the original netbsd code > o purge use of SVR4_SIGTBLZ; SVR4_NSIG is the only definition for > how big a mapping array is > o change the mapping loops to explicitly ignore signal 0 > o purge some bogus code from bsd_to_svr4_sigset > o adjust svr4_sysentvec to deal with the mapping table change > > Enticed into fixing by: Coverity Prevent analysis tool > Glanced at by: marcel, jhb Note that I do not have an svr4 binaries to run to test these changes. I wrote some test applications to verify the signal mapping logic but if someone can vet these changes with real use I'd appreciate it. FWIW all this came about because the Coverity tool pointed out an invalid array index that led me into this tarpit. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?421F7ED9.9050009>