Date: Wed, 16 Feb 2005 11:53:52 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: obrien@freebsd.org Cc: freebsd-emulation@freebsd.org Subject: Re: AMD64 patch for 'ports/x11-toolkits/linux-gtk' Message-ID: <20050216115352.iuw5qn60cowsokso@netchild.homeip.net> In-Reply-To: <20050216083118.GA37339@dragon.nuxi.com> References: <20050216081236.GA34471@dragon.nuxi.com> <20050216083118.GA37339@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien <obrien@freebsd.org> wrote: > On Wed, Feb 16, 2005 at 12:12:36AM -0800, David O'Brien wrote: > Any have a problem with this updated patch? > > 1. uses "ARCH" instead of "MACHINE_ARCH" What's the content of those variables on pc98? Will this port still work on those systems? You haven't replaced every instance of MACHINE_ARCH. Are you sure this also works after "make distclean"? > 2. allow "ARCH" to be over-ridable. > 3. fix ordering to better follow Mk/bsd.port.mk guidelines Looks ok ("s:ARCH:ONLY_FOR_ARCH:" in 2.). I suggest to investigate the linux-fontconfig part on your system instead of patching it in the ports tree. The directory is created just fine here (on i386). Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 The Golden Rule of Arts and Sciences: He who has the gold makes the rules.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050216115352.iuw5qn60cowsokso>