Date: Fri, 9 Oct 2015 14:53:55 +0200 From: Torsten Zuehlsdorff <mailinglists@toco-domains.de> To: =?UTF-8?Q?Martin_Waschb=c3=bcsch?= <martin@waschbuesch.de>, FreeBSD ports <freebsd-ports@freebsd.org> Subject: Re: Commiter needed for PR 200652 Message-ID: <5617B8E3.1070801@toco-domains.de> In-Reply-To: <BAAEFA33-7119-4A3F-AE8F-B7A73A20F547@waschbuesch.de> References: <BAAEFA33-7119-4A3F-AE8F-B7A73A20F547@waschbuesch.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200652 > > It's glue to use the existing ports > > p5-CGI-ExtDirect > p5-RPC-ExtDirect > > with plack environment. > > It's been open since June, so perhaps someone could take pity and commit it? :-D I'm not a committer, but i take a short look at it. I think you should make a little more QA. First i see there is a PORTEPOCH. Since this is a new port, this line should be there. Also you comment out an build dependency. Better to remove it completely. It is also a good idea to use "portlint -AC" against the new port and add some poudriere logs, which proves everything works fine. If you need any help with this, feel free to contact me. Greetings, Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5617B8E3.1070801>