Date: Wed, 31 May 2017 10:38:52 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Emmanuel Vadot <manu@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r319125 - head/usr.bin/mkimg Message-ID: <950A1301-50D2-490B-9598-5248AF246985@gmail.com> In-Reply-To: <20170531114829.28359de76187bdd184746b5a@bidouilliste.com> References: <201705291251.v4TCp24h090283@repo.freebsd.org> <FAFD6561-D529-4750-A72F-26767E65F6A5@gmail.com> <20170531114829.28359de76187bdd184746b5a@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On May 31, 2017, at 02:48, Emmanuel Vadot <manu@bidouilliste.com> wrote: >=20 > On Wed, 31 May 2017 00:20:45 -0700 > "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> wrote: >=20 >>=20 >>> On May 29, 2017, at 05:51, Emmanuel Vadot <manu@FreeBSD.org> wrote: >>>=20 >>> Author: manu >>> Date: Mon May 29 12:51:02 2017 >>> New Revision: 319125 >>> URL: https://svnweb.freebsd.org/changeset/base/319125 >>>=20 >>> Log: >>> mkimg: Correct an off by one error in the PMBR size >>>=20 >>> The PMBR last sector should be number of sector - 1 (As stated in UEFI S= pec >>> 2.6 page 118 table 17). >>> This fixes warning printed by linux tools like parted or fdisk. >>=20 >> This commit broke all of the mkimg gpt tests. For example: https://ci.fre= ebsd.org/job/FreeBSD-head-amd64-test/3280/testReport/junit/usr.bin.mkimg/mki= mg_test/gpt_1x1_4096_qcow/ . >> -Ngie >=20 > Sorry about that and thanks for the fix. No worries -- it turns out I broke something by accident as well, and I f= ixed both items at the same time. Take it easy :), -Ngie=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?950A1301-50D2-490B-9598-5248AF246985>