Date: Sat, 25 Apr 2026 16:03:45 +0100 From: Lexi Winter <ivy@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4822a2cf9900 - main - Tentative fix for powerpc boot1.chrp linking problem. Message-ID: <aezX0ba08z3cWtPy@amaryllis.le-fay.org> In-Reply-To: <69eccd95.36ae6.2c5a0592@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
hello,
thanks for the LLVM update!
Dimitry Andric wrote in <69eccd95.36ae6.2c5a0592@gitrepo.freebsd.org>:
> diff --git a/stand/powerpc/boot1.chrp/Makefile b/stand/powerpc/boot1.chrp/Makefile
> index 0b77bce2b097..8d0f970212d4 100644
> --- a/stand/powerpc/boot1.chrp/Makefile
> +++ b/stand/powerpc/boot1.chrp/Makefile
> @@ -23,6 +23,12 @@ CFLAGS+=-I${LDRSRC}
> #
> LDFLAGS=-nostdlib -static -Wl,-N -Wl,-Ttext=0x38000 -Wl,--image-base=0x38000
^^^^^^^^^^^^^^^^^^^^^^^^
>
> +.include <bsd.linker.mk>
> +.if (${LINKER_TYPE} == "bfd" && ${LINKER_VERSION} >= 24400) || \
> + ${LINKER_TYPE} == "lld"
> +LDFLAGS+=-Wl,--image-base=0
^^^^^^^^^^^^^^^^^^
> +.endif
> +
i already fixed this in a different way in aa0bc7cca153, which means
we now specify --image-base twice with different values. one of them
should probably be removed, but i don't have any particular opinion on
which is better.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQSyjTg96lp3RifySyn1nT63mIK/YAUCaezXzgAKCRD1nT63mIK/
YAVHAP9rTDztLEIl6b989ykEhHJ4hx51Qees22rg4u574ewQ0gD7BsQUXpH6Q459
dJaG7eXUpcyKpQc26r5eC06YfJJWmQQ=
=dAbB
-----END PGP SIGNATURE-----
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aezX0ba08z3cWtPy>