Date: Sat, 23 Nov 2019 23:44:00 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r355038 - head/sys/geom Message-ID: <201911232344.xANNi0nZ097880@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Sat Nov 23 23:44:00 2019 New Revision: 355038 URL: https://svnweb.freebsd.org/changeset/base/355038 Log: We don't even need Giant here. It isn't protecting anything internal to geom, and nothing we call requires it to be held. It's left over from a time when the latter wasn't the case. Retire it. Reviewed in concept: scottl@ Modified: head/sys/geom/geom_ctl.c Modified: head/sys/geom/geom_ctl.c ============================================================================== --- head/sys/geom/geom_ctl.c Sat Nov 23 23:43:52 2019 (r355037) +++ head/sys/geom/geom_ctl.c Sat Nov 23 23:44:00 2019 (r355038) @@ -68,7 +68,7 @@ static d_ioctl_t g_ctl_ioctl; static struct cdevsw g_ctl_cdevsw = { .d_version = D_VERSION, - .d_flags = D_NEEDGIANT, + .d_flags = 0, .d_ioctl = g_ctl_ioctl, .d_name = "g_ctl", };
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201911232344.xANNi0nZ097880>