Date: Thu, 10 Jul 2014 14:39:31 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, Pietro Cerutti <gahr@freebsd.org> Subject: Re: svn commit: r268491 - head/usr.bin/users Message-ID: <CACVs6=91pfiVV4sgo0sAebprKTa4FVYF2bW=mDDu518BCUtgqA@mail.gmail.com> In-Reply-To: <CAJOYFBDb%2BCxn%2BfN=qFfugf6ftmQU%2By8SM3c3nBczxm6u7_BMwg@mail.gmail.com> References: <201407101215.s6ACF3v1055260@svn.freebsd.org> <CAJOYFBCQjjN7ep12zivnmFjfeeP1SeoYa963mQbMJr9DD%2BfUnw@mail.gmail.com> <20140710152353.GF1812@ptrcrt.ch> <CAJOYFBDZiEpQ5e86%2BdBhRZobSjdf785bKBwh%2B3Eywhzn_iJJCQ@mail.gmail.com> <20140710154213.GG1812@ptrcrt.ch> <20140710155342.GB93051@ivaldir.etoilebsd.net> <CAJOYFBCMtnrdM96H9F86UsU=-7w-97N%2BKdBqYGihugD3W0%2BrbA@mail.gmail.com> <20140710160506.GH1812@ptrcrt.ch> <CAJOYFBDb%2BCxn%2BfN=qFfugf6ftmQU%2By8SM3c3nBczxm6u7_BMwg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 10, 2014 at 9:11 AM, Ed Schouten <ed@80386.nl> wrote: > On 10 July 2014 18:05, Pietro Cerutti <gahr@freebsd.org> wrote: > > I reply to this one, since I'm not on src-all. > > > > - for consistency, I'd s|std::set|set| > > - return (0) is not needed in c++ > > Good catch. Fixed! > If we're going to have more C++ in base we may want to pause and think about style(9) for C++ briefly. I'm not sure implicit return is something that fits the rest of the FreeBSD style, for instance.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACVs6=91pfiVV4sgo0sAebprKTa4FVYF2bW=mDDu518BCUtgqA>