Date: Tue, 13 May 2003 09:34:11 +0200 From: Johan Karlsson <johan@freebsd.org> To: Max Khon <fjoe@iclub.nsu.ru> Cc: FreeBSD-audit <audit@freebsd.org> Subject: Re: realpath(3) Message-ID: <20030513073411.GA96739@numeri.campus.luth.se> In-Reply-To: <20030512155847.GA5689@iclub.nsu.ru> References: <20030512155847.GA5689@iclub.nsu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi On Mon, May 12, 2003 at 22:58 (+0700) +0000, Max Khon wrote: > hi, there! > > I am going to MFC realpath(3) and would like to get another round of > review before MFC. Please look at > > http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/realpath.c?rev=1.19&content-type=text/x-cvsweb-markup There are three realy minor things found by trying to make the code WARNS=6 clean. The comparisions on line 94 and line 173 comapares unsigned versus signed. The variable 'symlink' shadows a function from unistd.h and should be chnaged. Thanks for doing the MFC. /Johan K > > /fjoe > > _______________________________________________ > freebsd-audit@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-audit > To unsubscribe, send any mail to "freebsd-audit-unsubscribe@freebsd.org" -- Johan Karlsson mailto:johan@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030513073411.GA96739>