Date: Sun, 25 Mar 2018 11:31:04 -0600 From: Warner Losh <imp@bsdimp.com> To: Ian Lepore <ian@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331532 - head/sys/crypto/ccp Message-ID: <CANCZdfo9dd0Yaq6y0e%2BYHBDFOV1M=m7P142Y%2BvD_JjgSvfdgiw@mail.gmail.com> In-Reply-To: <1521997216.49673.2.camel@freebsd.org> References: <201803251656.w2PGunC0061278@repo.freebsd.org> <1521997216.49673.2.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 25, 2018 at 11:00 AM, Ian Lepore <ian@freebsd.org> wrote: > On Sun, 2018-03-25 at 16:56 +0000, Warner Losh wrote: > > Author: imp > > Date: Sun Mar 25 16:56:49 2018 > > New Revision: 331532 > > URL: https://svnweb.freebsd.org/changeset/base/331532 > > > > Log: > > The PNP info has to follow the module definition. Move it from just > > after the array to its proper location. Otherwise, the linker.hints > > file has things out of order and we associated it with whatever was > > the previous module. > > Wow, that seems like a subtle thing that'll be easy to get wrong and > hard to detect when you have. Would it be possible for the PNP macro > to have some kind of reference to the structures generated by the > module definition macro, to force a compile-time error if they're out > of order? > Yes. I'm working on the best way to enforce it. The easy way is in kldxref, but I'm pondering ways to do it at compile time. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo9dd0Yaq6y0e%2BYHBDFOV1M=m7P142Y%2BvD_JjgSvfdgiw>