Date: Fri, 24 Apr 2020 13:21:54 +0200 From: Fabian Keil <freebsd-listen@fabiankeil.de> To: Xin LI <delphij@gmail.com> Cc: Johan Hendriks <joh.hendriks@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org>, Brooks Davis <brooks@freebsd.org>, "M. Warner Losh" <imp@freebsd.org>, Glen Barber <gjb@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org>, Ed Maste <emaste@freebsd.org>, Brad Davis <brd@freebsd.org> Subject: Re: Ordering of files in zoneinfo Message-ID: <20200424132144.7b0bb922@fabiankeil.de> In-Reply-To: <CAGMYy3sw8Jb=SCL=qK%2BQVfuc379fJSSU-nLT1REO-Ncs7r1oCg@mail.gmail.com> References: <202004171047.03HAlFk6050161@gndrsh.dnsmgr.net> <f2e0f78b-32be-a5f3-b885-737be6ddbfd6@gmail.com> <e933c7c1-5068-dc9a-e4e3-77b004ccf8cd@gmail.com> <CAGMYy3sw8Jb=SCL=qK%2BQVfuc379fJSSU-nLT1REO-Ncs7r1oCg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Xin LI <delphij@gmail.com> wrote: > I have took a look at the change history, it seems that the find > operation was introduced in r245265 > <https://svnweb.freebsd.org/base?view=revision&revision=245265>; (brooks@, > to support packaged base) and sort was initially implemented as find -s > in r289451 > <https://svnweb.freebsd.org/base?view=revision&revision=289451>; (ngie@, > to make METALOG reproducible) then as sort in r328958 > <https://svnweb.freebsd.org/base?view=revision&revision=328958>; (imp@, > for portability). > > I wonder if we could drop the sort and replace ${TZS} in line 100 with > ${TZS:O} instead? Makes sense to me. > By the way, looking at > https://github.com/freebsd/pkg/blob/master/libpkg/metalog.c , I wonder if > the sort should really happen in pkg(8) instead? Currently the METALOG is also used when creating the tarballs so sorting only in pkg would be insufficient as long as tarballs are still supported. Fabian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200424132144.7b0bb922>