Date: Tue, 17 Jan 2017 01:55:57 -0800 (PST) From: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> To: Ngie Cooper <ngie@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r312322 - stable/11/tests/sys/file Message-ID: <201701170955.v0H9tvtj071087@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201701170156.v0H1uiRs075082@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: ngie > Date: Tue Jan 17 01:56:44 2017 > New Revision: 312322 > URL: https://svnweb.freebsd.org/changeset/base/312322 > > Log: > MFC r312111: > > Remove unused vars to fix -Wunused issues The actual mistake here is that these are unused, a main() should do at least a check on argc to see if the correct number of args has been passed, and print a usage() if it has not: freebsd-rwg {105}% pwd /A/freebsd-rwg freebsd-rwg {106}% pwd foo usage: pwd [-LP] > Modified: > stable/11/tests/sys/file/ftruncate_test.c > Directory Properties: > stable/11/ (props changed) > > Modified: stable/11/tests/sys/file/ftruncate_test.c > ============================================================================== > --- stable/11/tests/sys/file/ftruncate_test.c Tue Jan 17 01:55:14 2017 (r312321) > +++ stable/11/tests/sys/file/ftruncate_test.c Tue Jan 17 01:56:44 2017 (r312322) > @@ -57,7 +57,7 @@ static off_t lengths[] = {0, 1, 2, 3, 4, > static int lengths_count = sizeof(lengths) / sizeof(off_t); > > int > -main(int argc, char *argv[]) > +main(void) > { > int error, fd, fds[2], i, read_only_fd; > char path[PATH_MAX]; > _______________________________________________ > svn-src-stable-11@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11 > To unsubscribe, send any mail to "svn-src-stable-11-unsubscribe@freebsd.org" > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701170955.v0H9tvtj071087>