Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Apr 2021 12:34:51 GMT
From:      Marcin Wojtas <mw@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 57dbb3c25936 - main - pci_dw: fix outbound I/O window configuration
Message-ID:  <202104061234.136CYpwh048402@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by mw:

URL: https://cgit.FreeBSD.org/src/commit/?id=57dbb3c25936f0d61fef152eb224ca86a73af0e9

commit 57dbb3c25936f0d61fef152eb224ca86a73af0e9
Author:     Marcin Wojtas <mw@FreeBSD.org>
AuthorDate: 2021-04-06 12:31:39 +0000
Commit:     Marcin Wojtas <mw@FreeBSD.org>
CommitDate: 2021-04-06 12:31:39 +0000

    pci_dw: fix outbound I/O window configuration
    
    Use viewport "2" instead of "0" and change window type from MEM to IO.
    Without these changes the MEM ATU window can be overwritten with the IO one.
    
    Submitted by: Kornel Duleba <mindal@semihalf.com>
    Obtained from: Semihalf
    Sponsored by: Marvell
    Differential revision: https://reviews.freebsd.org/D29516
---
 sys/dev/pci/pci_dw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/pci/pci_dw.c b/sys/dev/pci/pci_dw.c
index 33c6c0b070c3..161a68d2929d 100644
--- a/sys/dev/pci/pci_dw.c
+++ b/sys/dev/pci/pci_dw.c
@@ -231,7 +231,7 @@ pci_dw_setup_hw(struct pci_dw_softc *sc)
 	/* If we have enouht viewports ..*/
 	if (sc->num_viewport >= 3 && sc->io_range.size != 0) {
 		/* Setup outbound I/O window */
-		rv = pci_dw_map_out_atu(sc, 0, IATU_CTRL1_TYPE_MEM,
+		rv = pci_dw_map_out_atu(sc, 2, IATU_CTRL1_TYPE_IO,
 		    sc->io_range.host, sc->io_range.pci, sc->io_range.size);
 		if (rv != 0)
 			return (rv);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104061234.136CYpwh048402>