Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Jun 1999 09:15:57 +0100 (BST)
From:      Doug Rabson <dfr@nlsystems.com>
To:        Guido van Rooij <guido@gvr.org>
Cc:        Peter Wemm <peter@netplex.com.au>, cvs-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/isa sio.c
Message-ID:  <Pine.BSF.4.05.9906220915470.80685-100000@herring.nlsystems.com>
In-Reply-To: <19990621221816.A28898@gvr.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 21 Jun 1999, Guido van Rooij wrote:

> On Mon, Jun 21, 1999 at 10:37:27AM +0100, Doug Rabson wrote:
> > 
> > I would rather that people tackle these weaknesses by asking me how to
> > solve their problem or by suggesting new functionality for the 'approved'
> > api. I really think its a bad idea for drivers to use bus_private.h at
> > all.
> 
> You could actually even enforce this with some #define/#ifdef combination.
> (#define MAY_USE_INCLUDE_FILE in file.c
> #ifndef MAY_USE_INCLUDE_FILE
> 	#error Do not use this include file
> #endif
> 
> At least occasional errors like the one in sio.c can be prevented.

Bruce had the same idea.

--
Doug Rabson				Mail:  dfr@nlsystems.com
Nonlinear Systems Ltd.			Phone: +44 181 442 9037




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9906220915470.80685-100000>