Date: Tue, 10 Sep 2024 09:14:00 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: freebsd-hackers@freebsd.org Subject: Re: New lock-order reversal Message-ID: <0C85EBE5-53CD-414D-8B18-6E1F768DB58A@FreeBSD.org> In-Reply-To: <Zts4wtn7f8Twlops@troutmask.apl.washington.edu> References: <ZtslrWXXaSL74v0A@troutmask.apl.washington.edu> <72AF10E0-CB5A-4CB6-A50A-30A06DB7EA03@FreeBSD.org> <Zts4wtn7f8Twlops@troutmask.apl.washington.edu>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 6 Sep 2024, at 19:15, Steve Kargl wrote: > On Fri, Sep 06, 2024 at 06:49:48PM +0200, Kristof Provost wrote: >> I’ve had another look at this, and while I can probably avoid this >> for >> setting the tunnel function (basically by assuming setting it never >> fails or >> is already done, which is currently the case), I’m not happy with >> the only >> solution I see on the removal side (i.e. “don’t, just trust that >> the socket >> will be closed soon”). > > Thanks for the patch. I'll add to my kernel when I rebuild it. > Unfortuantely, I have way too little understanding about locking > within the kernel to be of much help. > I’m not very happy with that first patch. Can you try [https://reviews.freebsd.org/D46615](https://reviews.freebsd.org/D46615) and [https://reviews.freebsd.org/D46616](https://reviews.freebsd.org/D46616) instead? (That first patch is just cleanup, but you’ll probably want it to avoid conflicts.) Best regards, Kristof [-- Attachment #2 --] <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8"> </head> <body><div style="font-family: sans-serif;"><div class="markdown" style="white-space: normal;"> <p dir="auto">On 6 Sep 2024, at 19:15, Steve Kargl wrote:</p> </div><div class="plaintext" style="white-space: normal;"><blockquote style="margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136BCE; color: #136BCE;"><p dir="auto">On Fri, Sep 06, 2024 at 06:49:48PM +0200, Kristof Provost wrote:</p> <blockquote style="margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136BCE; border-left-color: #4B89CF; color: #4B89CF;"><p dir="auto">I’ve had another look at this, and while I can probably avoid this for <br> setting the tunnel function (basically by assuming setting it never fails or <br> is already done, which is currently the case), I’m not happy with the only <br> solution I see on the removal side (i.e. “don’t, just trust that the socket <br> will be closed soon”).</p> </blockquote><p dir="auto">Thanks for the patch. I'll add to my kernel when I rebuild it. <br> Unfortuantely, I have way too little understanding about locking <br> within the kernel to be of much help.</p> <br></blockquote></div> <div class="markdown" style="white-space: normal;"> <p dir="auto">I’m not very happy with that first patch.</p> <p dir="auto">Can you try <a href="https://reviews.freebsd.org/D46615">https://reviews.freebsd.org/D46615</a>; and <a href="https://reviews.freebsd.org/D46616">https://reviews.freebsd.org/D46616</a>; instead?</p> <p dir="auto">(That first patch is just cleanup, but you’ll probably want it to avoid conflicts.)</p> <p dir="auto">Best regards,<br> Kristof</p> </div> </div> </body> </html>help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0C85EBE5-53CD-414D-8B18-6E1F768DB58A>