Date: Thu, 27 Apr 2023 12:22:10 +0200 From: Yuri <yuri@aetern.org> To: current@freebsd.org Subject: Re: adopting zone1970.tab changes in tzsetup Message-ID: <7d47a1a9-069d-5817-6648-48dc542227f9@aetern.org> In-Reply-To: <4d4af609-e835-a702-0e7d-1d44fd0b686f@aetern.org> References: <4d4af609-e835-a702-0e7d-1d44fd0b686f@aetern.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yuri wrote: > Hi, > > After tzsetup was switched to use zone1970.tab in 513419f4047 it mostly > works, but there are some content changes compared to zone.tab that was > used previously which need to be taken care of (would like to do so > before 14.0). If you have spare time, please take a look at the reviews > below. > > https://reviews.freebsd.org/D39634 - add baseline to tzsetup to check > that zone1970.tab changes don't break the assumptions of file format we > make in tzsetup (and tzsetup changes itself don't have unintended effects) This one is integrated. > https://reviews.freebsd.org/D39606 - adopt zone1970.tab changes > - assumption that single-zone countries do not have description is no > longer correct; do not try to optimize this case as it's only going to > make the code more confusing and we now have menus with a single zone > selection because of this > - remove the single-country continent short cut, it also only serves to > confuse users as we now have such a continent > - instead add a single-zone contry short cut (see above), now all > single-zone countries fall here > - use the @# continent overrides that zone1970.tab introduces (this is > visible at least fixing Iceland being currently listed under Africa) > - add Arctic Ocean "continent" coming only from the overrides at the > moment > - update baseline with the changes And this one is waiting for review :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d47a1a9-069d-5817-6648-48dc542227f9>