Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Jun 2026 11:07:39 +0000
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Cc:        Jana Smith <thebugfixers@pm.me>
Subject:   git: be23edc1e402 - main - rack_bbr_common: don't use stale pointer after m_pullup()
Message-ID:  <6a41007b.39850.38a9aee1@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=be23edc1e4028e32a46e8fe7118de787fd5d79a2

commit be23edc1e4028e32a46e8fe7118de787fd5d79a2
Author:     Jana Smith <thebugfixers@pm.me>
AuthorDate: 2026-06-28 11:04:05 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2026-06-28 11:06:32 +0000

    rack_bbr_common: don't use stale pointer after m_pullup()
    
    Reviewed by:            tuexen
    MFC after:              1 week
    Differential Revision:  https://reviews.freebsd.org/D57816
---
 sys/netinet/tcp_stacks/rack_bbr_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netinet/tcp_stacks/rack_bbr_common.c b/sys/netinet/tcp_stacks/rack_bbr_common.c
index f90d84bb199d..51120f96ebce 100644
--- a/sys/netinet/tcp_stacks/rack_bbr_common.c
+++ b/sys/netinet/tcp_stacks/rack_bbr_common.c
@@ -173,7 +173,7 @@ ctf_get_enet_type(struct ifnet *ifp, struct mbuf *m)
 					return (-1);
 				}
 			}
-			ip6 = (struct ip6_hdr *)(eh + 1);
+			ip6 = mtod(m, struct ip6_hdr *);
 			th = (struct tcphdr *)(ip6 + 1);
 			drop_hdrlen = sizeof(*ip6);
 			tlen = ntohs(ip6->ip6_plen);
@@ -205,7 +205,7 @@ ctf_get_enet_type(struct ifnet *ifp, struct mbuf *m)
 					return (-1);
 				}
 			}
-			ip = (struct ip *)(eh + 1);
+			ip = mtod(m, struct ip *);
 			th = (struct tcphdr *)(ip + 1);
 			drop_hdrlen = sizeof(*ip);
 			iptos = ip->ip_tos;


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a41007b.39850.38a9aee1>