Date: Tue, 15 May 2007 08:12:41 +0200 From: des@des.no (Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?=) To: Alexander Leidinger <Alexander@Leidinger.net> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <861whiy5ra.fsf@dwp.des.no> In-Reply-To: <20070514172938.5v4yi78kisokk84s@webmail.leidinger.net> (Alexander Leidinger's message of "Mon\, 14 May 2007 17\:29\:38 %2B0200") References: <200705131815.l4DIFop9026874@repoman.freebsd.org> <20070514154040.0lofzrgm8kskgog4@webmail.leidinger.net> <86wszbqxbz.fsf@dwp.des.no> <20070514172938.5v4yi78kisokk84s@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Leidinger <Alexander@Leidinger.net> writes:
> Dag-Erling Smorgrav <des@FreeBSD.org> writes:
> > Alexander Leidinger <Alexander@Leidinger.net> writes:
> > > Why did you remove the echo?
> > which echo? about schg? it was completely bogus.
> Yes. I don't think so, please explain.
It would show up incorrectly if you declined to remove a file.
> > feel free to re-add it, but only if you also add logic to check whether
> > the file actually has the schg flag set before running chflags.
> In the current code it doesn't make sense, and the wording can be
> changed to tell that it will remove schg, in case this flag is set. As
> you did the change and I don't have time to commit such a change when
> I'm back at home (the place where I can make commits), would you
> please add the echo again?
That would mean an extra line of output for every single file...
> > > Why do you redirect stderr of chflags to /dev/null?
> > because chflags will complain if your /usr is on a file system which
> > does not support flags, such as NFS or ZFS.
> But it also removes any other failure message. A more sensible
> approach would be to replace the redirection with a "grep -v".
No, a more sensible approach would be to only remove schg if it is set.
> > > - bug(?): ${DESTDIR} in the rm line
> > no, this is intentional, and in fact the original code had it too.
> The original code hat it before, but you CD into DESTDIR, so it is not
> necessary anymore.
Unless someone goofs and adds an absolute path to ObsoleteFiles.inc...
which is why I very deliberately left "${DESTDIR}/" in front of the path
in the rm command, although I could probably replace it with "./".
DES
--
Dag-Erling Smørgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?861whiy5ra.fsf>