Date: Thu, 15 Nov 2012 15:20:06 -0800 From: Alfred Perlstein <bright@mu.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: attilio@FreeBSD.org, Ian Lepore <freebsd@damnhippie.dyndns.org>, Adrian Chadd <adrian@FreeBSD.org>, freebsd-hackers@FreeBSD.org, freebsd-arch@FreeBSD.org Subject: Re: [RFQ] make witness panic an option Message-ID: <50A578A6.1030005@mu.org> In-Reply-To: <50A555BD.1010105@FreeBSD.org> References: <CAJ-Vmo=i=Amo_QqHi4GnGie0Gc0YnK3XaRKjvBO-=SFboFYPmA@mail.gmail.com> <1353001175.1217.153.camel@revolution.hippie.lan> <CAJ-FndBP5Pi=SCpyBLK3b=HM_gQ9u8M4%2B1tLk9tA5X-gqismVA@mail.gmail.com> <1353009310.1217.172.camel@revolution.hippie.lan> <CAJ-Vmo=S3a1pyLHOe%2BSayVNDe=mAogQnkNpnSTakpOm56EdOUQ@mail.gmail.com> <50A555BD.1010105@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/15/12 12:51 PM, Andriy Gapon wrote: > on 15/11/2012 22:00 Adrian Chadd said the following: >> But I think my change is invaluable for development, where you want to >> improve and debug the locking and lock interactions of a subsystem. > My practical experience was that if you mess up one lock in one place, then it > is a total mess further on. but apparently you've got a different practical > experience :-) > > What would indeed be invaluable to _me_ - if the LOR messages also produced the > stack(s) where a supposedly correct lock order was learned. > Adrian is right. In a large scale environment breakages will be introduced in places you do not have access to. We need to enable developers to skip these areas and test their own code. Without Adrian's concept then it forces someone who may have no idea about a subsystem to either be blocked, or to have to put his work aside to work on a problem that is someone else's responsibility. I locked down SMP at a large company in a FreeBSD code base and had this same problem. Adrian's patch would have helped all of us tremendously. Adrian, can you look at my suggestion to merge with witness_kdb and see if that will suffice? -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50A578A6.1030005>