Date: Thu, 13 Apr 1995 11:11:32 -0400 From: Garrett Wollman <wollman@halloran-eldar.lcs.mit.edu> To: terry@cs.weber.edu (Terry Lambert) Cc: current@FreeBSD.org Subject: Broken PCI code Message-ID: <9504131511.AA08742@halloran-eldar.lcs.mit.edu> In-Reply-To: <9504122239.AA19512@cs.weber.edu> References: <9504121934.AA07483@halloran-eldar.lcs.mit.edu> <9504122239.AA19512@cs.weber.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
<<On Wed, 12 Apr 95 16:39:04 MDT, terry@cs.weber.edu (Terry Lambert) said: >> A special raspberry goes to the PCI code, for getting the idea almost >> completely inside-out. This is supposed to be DRIVER-driven, not >> generic-bus-code-driven. I don't want to go fiddling fifteen >> different PCI structures to provide the necessary information next >> time I add a variable to the devconf interface! > It was my impression that a bus attach *is* the way to handle the > ISA, EISA, PCI, and VESA stuff. > The thing I disagree with, which is what I think you are complaining > about too, is that the drivers themselves should be largely unaware > of what bus or whatever they are on. Nothing of the sort. What I am complaining about is that the PCI code goes to great lengths to (incorrectly) hide the devconf interface from PCI drivers, forcing one to go through enormous contortions to wedge every new addition to devconf (or even to make existing features work right) into various PCI data structures to ensure that the fifteen lines of fill-it-in-and-forget-it PCI code is able to provide something approximately similar to the correct values. If the PCI people don't fix this relatively soon, I'll probably go and fix it myself. -GAWollman -- Garrett A. Wollman | Shashish is simple, it's discreet, it's brief. ... wollman@lcs.mit.edu | Shashish is the bonding of hearts in spite of distance. Opinions not those of| It is a bond more powerful than absence. We like people MIT, LCS, ANA, or NSA| who like Shashish. - Claude McKenzie + Florent Vollant
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9504131511.AA08742>