Date: Tue, 4 Jul 2023 04:07:14 +0000 (UTC) From: Pedro Giffuni <pfg@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4456846a1a0d - main - bin/date: Upgrade calculations Message-ID: <1767168745.2134945.1688443634249@mail.yahoo.com> In-Reply-To: <CANCZdfrSnS5Xq020jwsY-pgmTCJEn5Ka3Zr5vqt6OK%2Buawc4tA@mail.gmail.com> References: <202307040308.36438MTA093771@gitrepo.freebsd.org> <CANCZdfqMvf1QuS=fNQjRPe3YUbp1zPQW4aorh=VTRHk%2Bf_e8qg@mail.gmail.com> <1037448433.54513.1688441647903@mail.yahoo.com> <CANCZdfrSnS5Xq020jwsY-pgmTCJEn5Ka3Zr5vqt6OK%2Buawc4tA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_2134944_1918056855.1688443634248
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
(Sorry for top posting)
Oh yes, the analysis is fine, and it is quicker to fix than what I had in m=
ind.
I'll take a look at fixing it now, but due to external issues I may have to=
leave the fix for next weekend.
Pedro.
On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <imp@bsdimp.c=
om> wrote: =20
=20
=20
On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <pfg@freebsd.org> wrote:
Hmm ...
Dragonfly has no armv7 or i386, so they didn't get it too wrong.I guess=C2=
=A0the int64_t would be a quick fix or another option, which I was considei=
rng, was to look at unsigning it but taking care of the edge cases ... I wa=
s too lazy for that.
Please go ahead and do the quick fix ;)
What makes you say it's a quick fix? If the calculations need 64 bits, int6=
4_t is the proper data type. How is that analysis wrong?
Also, it's tradition that you should fix it...
Warner =20
------=_Part_2134944_1918056855.1688443634248
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<html><head></head><body><div class=3D"ydpa7de5f4ayahoo-style-wrap" style=
=3D"font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px=
;"><div></div>
<div dir=3D"ltr" data-setdir=3D"false">(Sorry for top posting)</div=
><div><br></div><div dir=3D"ltr" data-setdir=3D"false">Oh yes, the analysis=
is fine, and it is quicker to fix than what I had in mind.</div><div dir=
=3D"ltr" data-setdir=3D"false"><br></div><div dir=3D"ltr" data-setdir=3D"fa=
lse">I'll take a look at fixing it now, but due to external issues I may ha=
ve to leave the fix for next weekend.</div><div><br></div><div dir=3D"ltr" =
data-setdir=3D"false">Pedro.</div><div><br></div><div><br></div>
=20
</div><div id=3D"ydp39addca9yahoo_quoted_9236065441" class=3D"ydp39=
addca9yahoo_quoted">
<div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, s=
ans-serif;font-size:13px;color:#26282a;">
=20
<div>
On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Lo=
sh <imp@bsdimp.com> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div id=3D"ydp39addca9yiv4277734352"><div><div><div><b=
r clear=3D"none"><br clear=3D"none"><div class=3D"ydp39addca9yiv4277734352g=
mail_quote"><div dir=3D"ltr" class=3D"ydp39addca9yiv4277734352gmail_attr">O=
n Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <<a shape=3D"rect" href=3D"mai=
lto:pfg@freebsd.org" rel=3D"nofollow" target=3D"_blank">pfg@freebsd.org</a>=
> wrote:<br clear=3D"none"></div><blockquote style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex;" class=3D"ydp39addca9yiv427773=
4352gmail_quote"><div><div style=3D"font-family:Helvetica Neue, Helvetica, =
Arial, sans-serif;font-size:16px;"><div></div>
<div dir=3D"ltr">Hmm ...</div><div dir=3D"ltr"><br clear=3D"none"><=
/div><div dir=3D"ltr">Dragonfly has no armv7 or i386, so they didn't get it=
too wrong.</div><div dir=3D"ltr">I guess <span><span style=3D"color:r=
gb(0,0,0);font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-siz=
e:16px;">the int64_t would be a quick fix or</span></span> another option, =
which I was consideirng, was to look at unsigning it but taking care of the=
edge cases ... I was too lazy for that.</div><div><br clear=3D"none"></div=
><div dir=3D"ltr">Please go ahead and do the quick fix ;)</div></div></div>=
</blockquote></div></div><div><br clear=3D"none"></div><div>What makes you =
say it's a quick fix? If the calculations need 64 bits, int64_t is the prop=
er data type. How is that analysis wrong?</div><div><br clear=3D"none"></di=
v><div>Also, it's tradition that you should fix it...</div><div><br clear=
=3D"none"></div><div>Warner</div></div><div id=3D"ydp39addca9yiv4277734352y=
qtfd43229" class=3D"ydp39addca9yiv4277734352yqt7218625191">
</div></div></div></div>
</div>
</div></body></html>
------=_Part_2134944_1918056855.1688443634248--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1767168745.2134945.1688443634249>